Skip to content

Fix too short title underlines/overlines in documentation#2094

Closed
dnskr wants to merge 2 commits into
astronomer:mainfrom
dnskr:fix-doc-title-underline-too-short
Closed

Fix too short title underlines/overlines in documentation#2094
dnskr wants to merge 2 commits into
astronomer:mainfrom
dnskr:fix-doc-title-underline-too-short

Conversation

@dnskr
Copy link
Copy Markdown
Contributor

@dnskr dnskr commented Nov 8, 2025

Description

The PR fixes the following warnings that are printed during documentation building:

./astronomer-cosmos/docs/configuration/operator-args.rst:42: WARNING: Title underline too short.
Overriding operator arguments per dbt node (or group of nodes)
------------------------------------------------------------- [docutils]


./astronomer-cosmos/docs/configuration/task-display-name.rst:4: WARNING: Title underline too short.
Task display name
================ [docutils]


./astronomer-cosmos/docs/getting_started/async-execution-mode.rst:21: WARNING: Title underline too short.
Getting Started with Airflow Async Mode
++++++++++++++++++++++++++++++++++ [docutils]


./astronomer-cosmos/docs/getting_started/custom-airflow-properties.rst:9: WARNING: Title underline too short.
Sample dbt Model YAML
++++++++++++ [docutils]


./astronomer-cosmos/docs/getting_started/watcher-execution-mode.rst:4: WARNING: Title underline too short.
Introducing ``ExecutionMode.WATCHER``: Experimental High-Performance dbt Execution in Cosmos
=============================================================================== [docutils]


./astronomer-cosmos/docs/getting_started/watcher-execution-mode.rst:13: WARNING: Title underline too short.
Background: The Problem with the Local Execution Mode in Cosmos
----------------------------------------------------------- [docutils]


./astronomer-cosmos/docs/getting_started/watcher-execution-mode.rst:97: WARNING: Title overline too short.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Example 1 — Using ``DbtDag`` with ``ExecutionMode.WATCHER``
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [docutils]


./astronomer-cosmos/docs/getting_started/watcher-execution-mode.rst:123: WARNING: Title overline too short.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Example 2 — Using ``DbtTaskGroup`` with ``ExecutionMode.WATCHER``
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [docutils]

Breaking Change?

No

Checklist

  • I have made corresponding changes to the documentation (if required)
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Copy Markdown
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnskr Thanks for fixing Sphinx warnings. Your PRs have great description and content.

Similar to the feedback given in:
#2096 (review)

I noticed PR #2095 also solves Sphinx errors. Please, unify these PRs into a single one (I'll close the other PR), giving the PR a generic title (e.g. docs: Fix Sphinx warnings).

If there are any other warnings being raised by Sphix, it would be great to have them fixed as part of this same PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.81%. Comparing base (975ebae) to head (cd2dbc7).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2094   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files          92       92           
  Lines        5951     5951           
=======================================
  Hits         5821     5821           
  Misses        130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dnskr dnskr closed this Nov 14, 2025
@dnskr dnskr mentioned this pull request Nov 14, 2025
2 tasks
@dnskr
Copy link
Copy Markdown
Contributor Author

dnskr commented Nov 14, 2025

Closed in favor of a single PR, as suggested in the review comment.

@tatiana tatiana reopened this Nov 17, 2025
tatiana pushed a commit that referenced this pull request Nov 17, 2025
## Description

This PR consolidates the following PRs that address documentation
formatting issues as suggested in the
[review](#2096 (review))
provided:
 - #2094
 - #2095
 - #2096
 - #2097

It also fixes the following issues:
```
./astronomer-cosmos/docs/getting_started/execution-modes.rst:209: WARNING: Explicit markup ends without a blank line; unexpected unindent. [docutils]
./astronomer-cosmos/docs/getting_started/execution-modes.rst:236: WARNING: Explicit markup ends without a blank line; unexpected unindent. [docutils]
./astronomer-cosmos/docs/getting_started/execution-modes.rst:293: WARNING: Explicit markup ends without a blank line; unexpected unindent. [docutils]
./astronomer-cosmos/docs/getting_started/execution-modes.rst:329: WARNING: Explicit markup ends without a blank line; unexpected unindent. [docutils]
./astronomer-cosmos/docs/getting_started/gcp-cloud-run-job.rst:6: WARNING: Explicit markup ends without a blank line; unexpected unindent. [docutils]
```

## Breaking Change?

No

## Checklist

- [ ] I have made corresponding changes to the documentation (if
required)
- [ ] I have added tests that prove my fix is effective or that my
feature works
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 17, 2025

Deploy Preview for sunny-pastelito-5ecb04 canceled.

Name Link
🔨 Latest commit 84ff1f3
🔍 Latest deploy log https://app.netlify.com/projects/sunny-pastelito-5ecb04/deploys/691b0c971ab1ef00080cb777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants