Skip to content

Add note about experimenting threads count for the Watcher Execution mode#2083

Merged
pankajkoti merged 2 commits into
mainfrom
watcher-threads-note
Nov 10, 2025
Merged

Add note about experimenting threads count for the Watcher Execution mode#2083
pankajkoti merged 2 commits into
mainfrom
watcher-threads-note

Conversation

@pankajkoti
Copy link
Copy Markdown
Contributor

@pankajkoti pankajkoti commented Nov 5, 2025

This PR adds documentation explaining how to configure and optimize thread counts when using the ExecutionMode.WATCHER mode in Cosmos. It provides practical guidance on thread configuration and its performance impact.

  • Adds a note with best practices for configuring the threads parameter
  • Includes benchmark results showing performance improvements from 1 to 16 threads
  • Provides two configuration examples: via profiles.yml and via Cosmos ProfileConfig

closes: #2081

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.81%. Comparing base (975ebae) to head (ecd4a16).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2083   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files          92       92           
  Lines        5951     5951           
=======================================
  Hits         5821     5821           
  Misses        130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread docs/getting_started/watcher-execution-mode.rst Outdated
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 10, 2025

Deploy Preview for sunny-pastelito-5ecb04 ready!

Name Link
🔨 Latest commit ecd4a16
🔍 Latest deploy log https://app.netlify.com/projects/sunny-pastelito-5ecb04/deploys/6911b9b03d98c3000775a596
😎 Deploy Preview https://deploy-preview-2083--sunny-pastelito-5ecb04.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pankajkoti pankajkoti marked this pull request as ready for review November 10, 2025 10:11
Copilot AI review requested due to automatic review settings November 10, 2025 10:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation explaining how to configure and optimize thread counts when using the ExecutionMode.WATCHER mode in Cosmos. It provides practical guidance on thread configuration and its performance impact.

  • Adds a note with best practices for configuring the threads parameter
  • Includes benchmark results showing performance improvements from 1 to 16 threads
  • Provides two configuration examples: via profiles.yml and via Cosmos ProfileConfig

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you very much, @pankajkoti !

@pankajkoti pankajkoti merged commit dd3b1b0 into main Nov 10, 2025
85 checks passed
@pankajkoti pankajkoti deleted the watcher-threads-note branch November 10, 2025 12:48
@tatiana tatiana added this to the Cosmos 1.11.1 milestone Nov 10, 2025
tatiana pushed a commit that referenced this pull request Nov 12, 2025
…mode (#2083)

This PR adds documentation explaining how to configure and optimize
thread counts when using the `ExecutionMode.WATCHER` mode in Cosmos. It
provides practical guidance on thread configuration and its performance
impact.

- Adds a note with best practices for configuring the `threads`
parameter
- Includes benchmark results showing performance improvements from 1 to
16 threads
- Provides two configuration examples: via `profiles.yml` and via Cosmos
`ProfileConfig`

closes: #2081
(cherry picked from commit dd3b1b0)
@tatiana tatiana mentioned this pull request Nov 12, 2025
tatiana added a commit that referenced this pull request Nov 12, 2025
Bug fixes

* Fix ``ExecutionMode.WATCHER`` deadlock in Airflow 3.0 & 3.1 by
@tatiana in #2087
* Fix ``ExecutionMode.AIRFLOW_ASYNC`` ``TaskGroup`` XCom issue by
@tatiana in #2088
* Guard watcher callback exceptions to avoid hanging producer tasks by
@pankajkoti in #2101
* Fix SQL templated field rendering for dynamically mapped tasks in
Airflow 2 by @tatiana in #2119

Enhancements

* Remove usage of contextmanager in plugins for accessing connections in
Airflow >= 3.1.2 by @pankajkoti in #2073

Docs

* Improve ``ExecutionMode.AIRFLOW_ASYNC`` docs by @tatiana in #2103
* Add note about experimenting threads count for the Watcher Execution
mode by @pankajkoti in #2083
* Fix minor documentation formatting issue by @dnskrv in #2098
* Correct example YAML key from ``operator_args`` to ``operator_kwargs``
by @jx2lee in #2091

Others

* Fix broken CI due to fastapi incompatibility with cadwyn for Airflow 3
by @pankajkoti in #2076
* pre-commit autoupdate in #2078, #2104

related:
astronomer/oss-integrations-private#272
@tatiana tatiana mentioned this pull request Nov 12, 2025
tatiana added a commit that referenced this pull request Nov 13, 2025
Bug fixes

* Fix ``ExecutionMode.WATCHER`` deadlock in Airflow 3.0 & 3.1 by
@tatiana in #2087
* Fix ``ExecutionMode.AIRFLOW_ASYNC`` ``TaskGroup`` XCom issue by
@tatiana in #2088
* Guard watcher callback exceptions to avoid hanging producer tasks by
@pankajkoti in #2101
* Fix SQL templated field rendering for dynamically mapped tasks in
Airflow 2 by @tatiana in #2119

Enhancements

* Remove usage of contextmanager in plugins for accessing connections in
Airflow >= 3.1.2 by @pankajkoti in #2073

Docs

* Improve ``ExecutionMode.AIRFLOW_ASYNC`` docs by @tatiana in #2103
* Add note about experimenting threads count for the Watcher Execution
mode by @pankajkoti in #2083
* Fix minor documentation formatting issue by @dnskrv in #2098
* Correct example YAML key from ``operator_args`` to ``operator_kwargs``
by @jx2lee in #2091

Others

* Fix broken CI due to fastapi incompatibility with cadwyn for Airflow 3
by @pankajkoti in #2076
* pre-commit autoupdate in #2078, #2104

Closes: astronomer/oss-integrations-private#272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add note in documentation to try and tweak the threads count for optimal benefits using the ExecutionMode.WATCHER

3 participants