Add note about experimenting threads count for the Watcher Execution mode#2083
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2083 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 92 92
Lines 5951 5951
=======================================
Hits 5821 5821
Misses 130 130 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for sunny-pastelito-5ecb04 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
c48772f to
ecd4a16
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds documentation explaining how to configure and optimize thread counts when using the ExecutionMode.WATCHER mode in Cosmos. It provides practical guidance on thread configuration and its performance impact.
- Adds a note with best practices for configuring the
threadsparameter - Includes benchmark results showing performance improvements from 1 to 16 threads
- Provides two configuration examples: via
profiles.ymland via CosmosProfileConfig
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tatiana
left a comment
There was a problem hiding this comment.
Looks great, thank you very much, @pankajkoti !
…mode (#2083) This PR adds documentation explaining how to configure and optimize thread counts when using the `ExecutionMode.WATCHER` mode in Cosmos. It provides practical guidance on thread configuration and its performance impact. - Adds a note with best practices for configuring the `threads` parameter - Includes benchmark results showing performance improvements from 1 to 16 threads - Provides two configuration examples: via `profiles.yml` and via Cosmos `ProfileConfig` closes: #2081 (cherry picked from commit dd3b1b0)
Bug fixes * Fix ``ExecutionMode.WATCHER`` deadlock in Airflow 3.0 & 3.1 by @tatiana in #2087 * Fix ``ExecutionMode.AIRFLOW_ASYNC`` ``TaskGroup`` XCom issue by @tatiana in #2088 * Guard watcher callback exceptions to avoid hanging producer tasks by @pankajkoti in #2101 * Fix SQL templated field rendering for dynamically mapped tasks in Airflow 2 by @tatiana in #2119 Enhancements * Remove usage of contextmanager in plugins for accessing connections in Airflow >= 3.1.2 by @pankajkoti in #2073 Docs * Improve ``ExecutionMode.AIRFLOW_ASYNC`` docs by @tatiana in #2103 * Add note about experimenting threads count for the Watcher Execution mode by @pankajkoti in #2083 * Fix minor documentation formatting issue by @dnskrv in #2098 * Correct example YAML key from ``operator_args`` to ``operator_kwargs`` by @jx2lee in #2091 Others * Fix broken CI due to fastapi incompatibility with cadwyn for Airflow 3 by @pankajkoti in #2076 * pre-commit autoupdate in #2078, #2104 related: astronomer/oss-integrations-private#272
Bug fixes * Fix ``ExecutionMode.WATCHER`` deadlock in Airflow 3.0 & 3.1 by @tatiana in #2087 * Fix ``ExecutionMode.AIRFLOW_ASYNC`` ``TaskGroup`` XCom issue by @tatiana in #2088 * Guard watcher callback exceptions to avoid hanging producer tasks by @pankajkoti in #2101 * Fix SQL templated field rendering for dynamically mapped tasks in Airflow 2 by @tatiana in #2119 Enhancements * Remove usage of contextmanager in plugins for accessing connections in Airflow >= 3.1.2 by @pankajkoti in #2073 Docs * Improve ``ExecutionMode.AIRFLOW_ASYNC`` docs by @tatiana in #2103 * Add note about experimenting threads count for the Watcher Execution mode by @pankajkoti in #2083 * Fix minor documentation formatting issue by @dnskrv in #2098 * Correct example YAML key from ``operator_args`` to ``operator_kwargs`` by @jx2lee in #2091 Others * Fix broken CI due to fastapi incompatibility with cadwyn for Airflow 3 by @pankajkoti in #2076 * pre-commit autoupdate in #2078, #2104 Closes: astronomer/oss-integrations-private#272
This PR adds documentation explaining how to configure and optimize thread counts when using the
ExecutionMode.WATCHERmode in Cosmos. It provides practical guidance on thread configuration and its performance impact.threadsparameterprofiles.ymland via CosmosProfileConfigcloses: #2081