Fix/Ignore type check#2002
Closed
pankajastro wants to merge 3 commits into
Closed
Conversation
pankajastro
temporarily deployed
to
internal
GitHub Actions
Inactive
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
pankajastro
commented
Sep 26, 2025
pankajastro
temporarily deployed
to
internal
GitHub Actions
Inactive
pankajastro
commented
Sep 26, 2025
| strict = true | ||
| ignore_missing_imports = true | ||
| no_warn_unused_ignores = true | ||
| disable_error_code = ["misc"] |
Contributor
Author
There was a problem hiding this comment.
Lots of errors related to this check. shall we create an issue to track it?
cosmos/operators/local.py:970: error: Definition of "log" in base class "AbstractDbtBase" is incompatible with definition in base class "DAGNode" [misc]
cosmos/operators/local.py:1009: error: Definition of "log" in base class "AbstractDbtBase" is incompatible with definition in base class "DAGNode" [misc]
cosmos/operators/local.py:1020: error: Definition of "log" in base class "AbstractDbtBase" is incompatible with definition in base class "DAGNode" [misc]
cosmos/operators/local.py:1031: error: Definition of "log" in base class "AbstractDbtBase" is incompatible with definition in base class "DAGNode" [misc]
cosmos/operators/local.py:1042: error: Definition of "log" in base class "AbstractDbtBase" is incompatible with definition in base class "DAGNode" [misc]
cosmos/operators/local.py:1081: error: Definition of "log" in base class "AbstractDbtBase" is incompatible with definition in base class "DAGNode" [misc]
cosmos/operators/local.py:1092: error: Definition of "log" in base class "AbstractDbtBase" is incompatible with definition in base class "DAGNode" [misc]
cosmos/operators/local.py:1144: error: Definition of "log" in base class "AbstractDbtBase" is incompatible with definition in base class "DAGNode" [misc]
cosmos/operators/local.py:1185: error: Definition of "log" in base class "AbstractDbtBase" is incompatible with definition in base class "DAGNode" [misc]
cosmos/operators/local.py:1386: error: Definition of "log" in base class "AbstractDbtBase" is incompatible with definition in base class "DAGNode" [misc]
cosmos/operators/local.py:1394: error: Definition of "log" in base class "AbstractDbtBase" is incompatible with definition in base class "DAGNode" [misc]
cosmos/operators/watcher.py:19: error: Name "BaseSensorOperator" already defined (possibly by an import) [no-redef]
cosmos/operators/virtualenv.py:238: error: Definition of "log" in base class "AbstractDbtBase" is incompatible with definition in base class "DAGNode" [misc]
cosmos/operators/virtualenv.py:260: error: Definition of "log" in base class "AbstractDbtBase" is incompatible with definition in base class "DAGNode" [misc]
cosmos/operators/virtualenv.py:272: error: Definition of "log" in base class "AbstractDbtBase" is incompatible with definition in base class "DAGNode" [misc]
cosmos/operators/virtualenv.py:294: error: Definition of "log" in base class "AbstractDbtBase" is incompatible with definition in base class "DAGNode" [misc]
cosmos/operators/virtualenv.py:316: error: Definition of "log" in base class "AbstractDbtBase" is incompatible with definition in base class "DAGNode" [misc]
cosmos/operators/virtualenv.py:328: error: Definition of "log" in base class "AbstractDbtBase" is incompatible with definition in base class "DAGNode" [misc]
cosmos/airflow/task_group.py:14: error: Class cannot subclass "TaskGroup" (has type "Any") [misc]
cosmos/airflow/dag.py:14: error: Class cannot subclass "DAG" (has type "Any") [misc]
Contributor
There was a problem hiding this comment.
I don't think we should disable this misc error code altogether
Contributor
Author
There was a problem hiding this comment.
We already have 17 type: ignore[misc] in the main branch, unless we align our classes with upstream unsure what we could do.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2002 +/- ##
==========================================
- Coverage 97.77% 97.76% -0.02%
==========================================
Files 87 87
Lines 5446 5455 +9
==========================================
+ Hits 5325 5333 +8
- Misses 121 122 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
closing in favour of #2003 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.