-
Notifications
You must be signed in to change notification settings - Fork 297
Fix running tests with dbt Fusion 2.0.0 preview versions #1948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
add5bd4
f30405f
ba3e092
2abc73b
1217efb
3819105
324c935
f4772f6
59ca2a3
107c2d0
e6aeb8c
8ba4258
50a3e5c
adfaee2
ae21942
32a30de
7e859a1
bd42441
dfce2aa
e564fdb
4cb37e1
b111bdc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -369,6 +369,8 @@ jobs: | |
| POSTGRES_PORT: 5432 | ||
| AIRFLOW__COSMOS__REMOTE_TARGET_PATH: "s3://cosmos-remote-cache/target_compiled/" | ||
| AIRFLOW__COSMOS__REMOTE_TARGET_PATH_CONN_ID: aws_s3_conn | ||
| DBT_PROJECT_NAME: "altered_jaffle_shop" # The syntax of jaffle_shop is not supported in dbt 1.5.4, only in dbt >= 1.10 | ||
| TEST_SINGLE_DAG: "basic_cosmos_task_group.py" | ||
|
|
||
| Run-Integration-Tests-DBT-Async: | ||
| needs: Authorize | ||
|
|
@@ -380,7 +382,7 @@ jobs: | |
| matrix: | ||
| python-version: [ "3.11" ] | ||
| airflow-version: [ "2.11", "3.0" ] | ||
| dbt-version: ["1.5", "1.6", "1.7", "1.8", "1.9", "1.10"] | ||
| dbt-version: ["1.6", "1.7", "1.8", "1.9", "1.10"] | ||
|
tatiana marked this conversation as resolved.
|
||
| services: | ||
| postgres: | ||
| image: postgres@sha256:4cd697181d4bd3ddc41a09012f339fa8cb5a8cd3d8b30130ea8378c176b6c494 # 14.18 | ||
|
|
@@ -421,16 +423,6 @@ jobs: | |
| - name: Test Cosmos against Airflow ${{ matrix.airflow-version }}, Python ${{ matrix.python-version }} and dbt ${{ matrix.dbt-version }} | ||
| run: | | ||
| hatch run tests.py${{ matrix.python-version }}-${{ matrix.airflow-version }}-${{ matrix.dbt-version }}:test-integration-dbt-async | ||
| env: | ||
| AIRFLOW_HOME: /home/runner/work/astronomer-cosmos/astronomer-cosmos/ | ||
| AIRFLOW_CONN_AWS_S3_CONN: ${{ secrets.AIRFLOW_CONN_AWS_S3_CONN }} | ||
| AIRFLOW_CONN_GCP_GS_CONN: ${{ secrets.AIRFLOW_CONN_GCP_GS_CONN }} | ||
| AIRFLOW__CORE__DAGBAG_IMPORT_TIMEOUT: 90.0 | ||
| PYTHONPATH: /home/runner/work/astronomer-cosmos/astronomer-cosmos/:$PYTHONPATH | ||
| AIRFLOW__COSMOS__ENABLE_CACHE: 0 | ||
| AIRFLOW__COSMOS__REMOTE_TARGET_PATH: "s3://cosmos-remote-cache/target_compiled/" | ||
| AIRFLOW__COSMOS__REMOTE_TARGET_PATH_CONN_ID: aws_s3_conn | ||
| DBT_ADAPTER_VERSION: ${{ matrix.dbt-version }} | ||
|
|
||
| - name: Upload coverage to Github | ||
| uses: actions/upload-artifact@v4 | ||
|
|
@@ -441,9 +433,27 @@ jobs: | |
|
|
||
| env: | ||
| AIRFLOW_HOME: /home/runner/work/astronomer-cosmos/astronomer-cosmos/ | ||
| AIRFLOW_CONN_EXAMPLE_CONN: postgres://postgres:postgres@0.0.0.0:5432/postgres | ||
| PYTHONPATH: /home/runner/work/astronomer-cosmos/astronomer-cosmos/:$PYTHONPATH | ||
|
|
||
| DBT_PROJECT_NAME: "altered_jaffle_shop" # The syntax of jaffle_shop is not supported in dbt 1.5.4, only in dbt >= 1.10 | ||
| AIRFLOW__COSMOS__ENABLE_DATASET_ALIAS: 0 | ||
|
tatiana marked this conversation as resolved.
|
||
| AIRFLOW_CONN_AWS_S3_CONN: ${{ secrets.AIRFLOW_CONN_AWS_S3_CONN }} | ||
| AIRFLOW_CONN_GCP_GS_CONN: ${{ secrets.AIRFLOW_CONN_GCP_GS_CONN }} | ||
| AIRFLOW__CORE__DAGBAG_IMPORT_TIMEOUT: 90.0 | ||
| AIRFLOW__COSMOS__ENABLE_CACHE: 0 | ||
| AIRFLOW__COSMOS__REMOTE_TARGET_PATH: "s3://cosmos-remote-cache/target_compiled/" | ||
| AIRFLOW__COSMOS__REMOTE_TARGET_PATH_CONN_ID: aws_s3_conn | ||
| DBT_ADAPTER_VERSION: ${{ matrix.dbt-version }} | ||
|
|
||
| # The following are only required because the profiles.yml file references them. They are not used by the tests selected by this job. | ||
| AIRFLOW_CONN_EXAMPLE_CONN: postgres://postgres:postgres@0.0.0.0:5432/postgres | ||
| POSTGRES_HOST: localhost | ||
| POSTGRES_USER: postgres | ||
| POSTGRES_PASSWORD: postgres | ||
| POSTGRES_DB: postgres | ||
| POSTGRES_SCHEMA: public | ||
| POSTGRES_PORT: 5432 | ||
|
Comment on lines
+438
to
+455
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a reason we need to move those environment variables here? Our other jobs have most of the environment variables localised to the step that runs the tests.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I didn't realise we were trying to keep the envvars closer to the step, sorry. We can revert this change in a future change to |
||
|
|
||
| Run-Integration-dbt-fusion-Tests: | ||
| needs: Authorize | ||
| runs-on: ubuntu-latest | ||
|
|
@@ -614,7 +624,7 @@ jobs: | |
| matrix: | ||
| python-version: [ "3.12" ] | ||
| airflow-version: [ "2.10", "3.0" ] | ||
| dbt-version: [ "1.9" ] | ||
| dbt-version: [ "1.10" ] | ||
|
tatiana marked this conversation as resolved.
|
||
| steps: | ||
| - uses: actions/checkout@v5 | ||
| with: | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.