-
Notifications
You must be signed in to change notification settings - Fork 296
Set CosmosPlugin to None for airflow 3 #1698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,19 @@ | ||
| from __future__ import annotations | ||
|
|
||
| from typing import TYPE_CHECKING | ||
|
|
||
| from airflow import __version__ as airflow_version | ||
| from packaging import version | ||
|
|
||
| from cosmos.constants import _AIRFLOW3_MAJOR_VERSION | ||
|
|
||
| if TYPE_CHECKING: # pragma: no cover | ||
| from .plugin_impl import CosmosPlugin as _CosmosPluginType | ||
|
|
||
| CosmosPlugin: _CosmosPluginType | None = None | ||
| # The plugin is only loaded if the Airflow version is less than 3.0. This is because the plugin is incompatible with | ||
| # Airflow 3.0 and above. Once the compatibility issue is resolved as part of | ||
| # https://github.com/astronomer/astronomer-cosmos/issues/1587, the import statement can be moved outside of the | ||
| # conditional block. | ||
| if version.parse(airflow_version).major < _AIRFLOW3_MAJOR_VERSION: | ||
| from .plugin_impl import CosmosPlugin as CosmosPlugin | ||
| from .plugin_impl import CosmosPlugin as CosmosPlugin # type: ignore[assignment] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # This module is added specifically to test that the plugin is disabled in Airflow 3.x. | ||
| # Currently, we skip the entire test_plugin.py module since it contains multiple tests that are only compatible with Airflow 2.x. | ||
| # Adding this test to that file would require selectively applying pytest.mark.skipif to each individual test, | ||
| # which would add unnecessary complexity. | ||
| # To keep things straightforward, we isolate the one relevant test for Airflow 3 here, | ||
| # while continuing to skip the existing plugin test module entirely for Airflow 3.x. | ||
| import pytest | ||
| from airflow import __version__ as airflow_version | ||
| from packaging import version | ||
|
|
||
| import cosmos.plugin | ||
|
|
||
|
|
||
| @pytest.mark.skipif(version.parse(airflow_version).major == 2, reason="Plugin is available in Airflow 2.x") | ||
| def test_cosmos_plugin_disabled_on_airflow3(): | ||
| assert cosmos.plugin.CosmosPlugin is None |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.