Skip to content

Implement dbt exposure selector#1559

Closed
ghjklw wants to merge 2 commits into
astronomer:mainfrom
ghjklw:feature-exposure-selector
Closed

Implement dbt exposure selector#1559
ghjklw wants to merge 2 commits into
astronomer:mainfrom
ghjklw:feature-exposure-selector

Conversation

@ghjklw
Copy link
Copy Markdown
Contributor

@ghjklw ghjklw commented Feb 24, 2025

Description

Implement dbt exposure selector, following exactly the same pattern as source.

Related Issue(s)

Closes #1551

Breaking Change?

No

Checklist

  • I have made corresponding changes to the documentation (if required)
  • I have added tests that prove my fix is effective or that my feature works

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 24, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 24, 2025 •
edited
Loading

✅ Deploy Preview for sunny-pastelito-5ecb04 ready!

Name Link
🔨 Latest commit 521a943
🔍 Latest deploy log https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/67c10c5f831d060008b3bda8
😎 Deploy Preview https://deploy-preview-1559--sunny-pastelito-5ecb04.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dosubot dosubot Bot added the area:selector Related to selector, like DAG selector, DBT selector, etc label Feb 24, 2025
@tatiana tatiana added this to the Cosmos 1.10.0 milestone Feb 27, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.31%. Comparing base (0811e46) to head (521a943).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
cosmos/dbt/selector.py 90.47% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1559      +/-   ##
==========================================
- Coverage   97.34%   97.31%   -0.03%     
==========================================
  Files          80       80              
  Lines        4903     4923      +20     
==========================================
+ Hits         4773     4791      +18     
- Misses        130      132       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tatiana
tatiana approved these changes Feb 28, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@tatiana tatiana left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great feature. Thank you for extending Cosmos selectors, @ghjklw !
Since it is a new feature, we'll be releasing this in Cosmos 1.10

I'm happy for us to merge this feature once the tests are passing - could you please address the codecov feedback?

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Feb 28, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 30, 2025

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Mar 30, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2025

This PR was closed because it has been inactive for 10 days since being marked as stale.

@github-actions github-actions Bot closed this Apr 9, 2025
@ghjklw ghjklw mentioned this pull request Apr 28, 2025
Merged
2 tasks
tatiana pushed a commit that referenced this pull request Apr 29, 2025
@ghjklw
Implement DBT exposure selector (#1717)
441f21a 
Implement dbt exposure selector, following exactly the same pattern as
source.
This is just an updated version of #1559 with the requested additional
unit test... sorry for the delay 🙈

Closes #1551
pankajkoti pushed a commit that referenced this pull request Apr 29, 2025
@ghjklw @pankajkoti
Implement DBT exposure selector (#1717)
2fe32c6 
Implement dbt exposure selector, following exactly the same pattern as
source.
This is just an updated version of #1559 with the requested additional
unit test... sorry for the delay 🙈

Closes #1551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tatiana tatiana tatiana approved these changes

Assignees

No one assigned

Labels

area:selector Related to selector, like DAG selector, DBT selector, etc lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed

Projects

None yet

Milestone

Cosmos 1.10.0

Development

Successfully merging this pull request may close these issues.

[Feature] exposure: selectors

2 participants

@ghjklw @tatiana