Fix source resource type tests by pankajastro · Pull Request #1405 · astronomer/astronomer-cosmos

pankajastro · 2024-12-18T15:06:22Z

jaffle_shop does not have a source so let's point the example_source_rendering.py to use the altered_jaffle_shop project.

cloudflare-workers-and-pages · 2024-12-18T15:08:15Z

Deploying astronomer-cosmos with Cloudflare Pages

Latest commit:	`7601277`
Status:	✅ Deploy successful!
Preview URL:	https://b95e0f67.astronomer-cosmos.pages.dev
Branch Preview URL:	https://fix-tests.astronomer-cosmos.pages.dev

View logs

codecov · 2024-12-18T18:44:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (0edb07d) to head (7601277).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1405      +/-   ##
==========================================
+ Coverage   96.28%   96.48%   +0.19%     
==========================================
  Files          68       68              
  Lines        4150     4150              
==========================================
+ Hits         3996     4004       +8     
+ Misses        154      146       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pankajastro · 2024-12-18T18:57:39Z

Created a follow-up issue: #1407 to see if we can avoid using outdated manifest file

pankajkoti

Nice fix 🚀

@wornjs

**New Features** * Support customizing Airflow operator arguments per dbt node by @wornjs in #1339. [More information](https://astronomer.github.io/astronomer-cosmos/getting_started/custom-airflow-properties.html). * Support uploading dbt artifacts to remote cloud storages via callback by @pankajkoti in #1389. [Read more](https://astronomer.github.io/astronomer-cosmos/configuration/callbacks.html). * Add support to ``TestBehavior.BUILD`` by @tatiana in #1377. [Documentation](https://astronomer.github.io/astronomer-cosmos/configuration/testing-behavior.html). * Add support for the "at" operator when using ``LoadMode.DBT_MANIFEST`` or ``CUSTOM`` by @benjy44 in #1372 * Add dbt clone operator by @pankajastro in #1326, as documented in [here](https://astronomer.github.io/astronomer-cosmos/getting_started/operators.html). * Support rendering tasks with non-ASCII characters by @t0momi219 in #1278 [Read more](https://astronomer.github.io/astronomer-cosmos/configuration/task-display-name.html) * Add warning callback on source freshness by @pankajastro in #1400 [Read more](https://astronomer.github.io/astronomer-cosmos/configuration/source-nodes-rendering.html#on-warning-callback-callback) * Add Oracle Profile mapping by @slords and @pankajkoti in #1190 and #1404 * Emit telemetry to Scarf during DAG run by @tatiana in #1397 * Save tasks map as ``DbtToAirflowConverter`` property by @internetcoffeephone and @hheemskerk in #1362 **Bug Fixes** * Fix the mock value of port in ``TrinoBaseProfileMapping`` to be an integer by @dwolfeu #1322 * Fix access to the ``dbt docs`` menu item outside of Astro cloud by @tatiana in #1312 * Add missing ``DbtSourceGcpCloudRunJobOperator`` in module ``cosmos.operators.gcp_cloud_run_job`` by @anai-s in #1290 * Support building ``DbtDag`` without setting paths in ``ProjectConfig`` by @tatiana in #1307 * Fix parsing dbt ls outputs that contain JSONs that are not dbt nodes by @tatiana in #1296 * Fix Snowflake Profile mapping when using AWS default region by @tatiana in #1406 * Fix dag rendering for taskflow + DbtTaskGroup combo by @pankajastro in #1360 **Enhancements** * Improve dbt command execution logs to troubleshoot ``None`` values by @tatiana in #1392 * Add logging of stdout to dbt graph run_command by @KarolGongola in #1390 * Save tasks map as DbtToAirflowConverter property by @internetcoffeephone and @hheemskerk in #1362 * Support rendering build operator task-id with non-ASCII characters by @pankajastro in #1415 **Docs** * Remove extra ` char from docs by @pankajastro in #1345 * Add limitation about copying target dir files to remote by @pankajkoti in #1305 * Generalise example from README by @ReadytoRocc in #1311 * Add security policy by @tatiana, @chaosmaw and @lzdanski in # 1385 * Mention in documentation that the callback functionality is supported in ``ExecutionMode.VIRTUALENV`` by @pankajkoti in #1401 **Others** * Restore Jaffle Shop so that ``basic_cosmos_dag`` works as documented by @tatiana in #1374 * Remove Pytest durations from tests scripts by @tatiana in #1383 * Remove typing-extensions as dependency by @pankajastro in #1381 * Pin dbt-databricks version to < 1.9 by @pankajastro in #1376 * Refactor ``dbt-sqlite`` tests to use ``dbt-postgres`` by @pankajastro in #1366 * Remove 'dbt-core<1.8.9' pin by @tatiana in #1371 * Remove dependency ``eval_type_backport`` by @tatiana in #1370 * Enable kubernetes tests for dbt>=1.8 by @pankajastro #1364 * CI Workaround: Pin dbt-core, Disable SQLite Tests, and Correctly Ignore Clone Test to Pass CI by @pankajastro in #1337 * Enable Azure task in the remote store manifest example DAG by @pankajkoti in #1333 * Enable GCP remote manifest task by @pankajastro in #1332 * Add exempt label option in GH action stale job by @pankajastro in #1328 * Add integration test for source node rendering by @pankajastro in #1327 * Fix vulnerability issue on docs dependency by @tatiana in #1313 * Add postgres pod status check for k8s tests in CI by @pankajkoti in #1320 * [CI] Reduce the amount taking to run tests in the CI from 5h to 11min by @tatiana in #1297 * Enable secret detection precommit check by @pankajastro in #1302 * Fix security vulnerability, by not pinning Airflow 2.10.0 by @tatiana in #1298 * Fix Netlify build timeouts by @tatiana in #1294 * Add stalebot to label/close stale PRs and issues by @tatiana in #1288 * Unpin dbt-databricks version by @pankajastro in #1409 * Fix source resource type tests by @pankajastro in #1405 * Increase performance tests models by @tatiana in #1403 * Drop running 1000 models in the CI by @pankajkoti in #1411 * Fix releasing package to PyPI by @tatiana in #1396 * Pre-commit hook updates in #1394, #1373, #1358, #1340, #1331, #1314, #1301 Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com> Co-authored-by: Pankaj Singh <pankaj.singh@astronomer.io> Closes: #1193 --------- Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com> Co-authored-by: Pankaj Singh <98807258+pankajastro@users.noreply.github.com>

Fix source resource type tests

047994f

pankajastro temporarily deployed to internal December 18, 2024 15:06 — with GitHub Actions Inactive

pankajastro marked this pull request as ready for review December 18, 2024 15:07

dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 18, 2024

dosubot Bot added the area:testing Related to testing, like unit tests, integration tests, etc label Dec 18, 2024

Fix project

c7ade0f

pankajastro temporarily deployed to internal December 18, 2024 15:48 — with GitHub Actions Inactive

Update tests

ffbfce2

dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Dec 18, 2024

pankajastro temporarily deployed to internal December 18, 2024 16:07 — with GitHub Actions Inactive

Fix tests

eed4425

pankajastro temporarily deployed to internal December 18, 2024 16:27 — with GitHub Actions Inactive

Fix tests

3647c89

pankajastro temporarily deployed to internal December 18, 2024 16:38 — with GitHub Actions Inactive

Update build test

54223df

pankajastro temporarily deployed to internal December 18, 2024 16:57 — with GitHub Actions Inactive

Fix

7601277

pankajastro temporarily deployed to internal December 18, 2024 18:24 — with GitHub Actions Inactive

tatiana approved these changes Dec 18, 2024

View reviewed changes

dosubot Bot added the lgtm This PR has been approved by a maintainer label Dec 18, 2024

tatiana merged commit 9820935 into main Dec 18, 2024

tatiana deleted the fix_tests branch December 18, 2024 20:02

pankajastro added this to the Cosmos 1.8.0 milestone Dec 18, 2024

pankajastro self-assigned this Dec 18, 2024

pankajkoti reviewed Dec 19, 2024

View reviewed changes

pankajkoti mentioned this pull request Dec 19, 2024

Release 1.8.0 #1395

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix source resource type tests#1405

Fix source resource type tests#1405
tatiana merged 7 commits into
mainfrom
fix_tests

pankajastro commented Dec 18, 2024 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages Bot commented Dec 18, 2024 •

edited

Loading

Uh oh!

codecov Bot commented Dec 18, 2024 •

edited

Loading

Uh oh!

pankajastro commented Dec 18, 2024 •

edited

Loading

Uh oh!

pankajkoti left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

pankajastro commented Dec 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cloudflare-workers-and-pages Bot commented Dec 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying astronomer-cosmos with Cloudflare Pages

Uh oh!

codecov Bot commented Dec 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pankajastro commented Dec 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pankajkoti left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pankajastro commented Dec 18, 2024 •

edited

Loading

cloudflare-workers-and-pages Bot commented Dec 18, 2024 •

edited

Loading

codecov Bot commented Dec 18, 2024 •

edited

Loading

pankajastro commented Dec 18, 2024 •

edited

Loading