[Bug] Accidentally attaching adapters to root logger leads to increased logging costs

cosmos/__init__.py

@@ -30,7 +30,7 @@
     DbtTestLocalOperator,
 )
 
-logger = get_logger()
+logger = get_logger(__name__)
 
 try:
     from cosmos.operators.docker import (

cosmos/cache.py

@@ -12,7 +12,7 @@
 from cosmos.dbt.project import get_partial_parse_path
 from cosmos.log import get_logger
 
-logger = get_logger()
+logger = get_logger(__name__)
 
 
 # It was considered to create a cache identifier based on the dbt project path, as opposed

cosmos/dbt/project.py

@@ -13,7 +13,7 @@
 )
 from cosmos.log import get_logger
 
-logger = get_logger()
+logger = get_logger(__name__)
 
 
 def has_non_empty_dependencies_file(project_path: Path) -> bool:

cosmos/log.py

@@ -14,8 +14,10 @@
     "%(log_color)s%(message)s%(reset)s"
 )
 
+LOGGER_NAME_TEMPLATE = "astronomer-cosmos-{}"
 
-def get_logger(name: str | None = None) -> logging.Logger:
+
+def get_logger(name: str) -> logging.Logger:
     """
     Get custom Astronomer cosmos logger.
 
@@ -25,7 +27,7 @@ def get_logger(name: str | None = None) -> logging.Logger:
     By using this logger, we introduce a (yellow) astronomer-cosmos string into the project's log messages:
     [2023-08-09T14:20:55.532+0100] {subprocess.py:94} INFO - (astronomer-cosmos) - 13:20:55  Completed successfully
     """
-    logger = logging.getLogger(name)
+    logger = logging.getLogger(LOGGER_NAME_TEMPLATE.format(name))
     formatter: logging.Formatter = CustomTTYColoredFormatter(fmt=LOG_FORMAT)  # type: ignore
     handler = logging.StreamHandler()
     handler.setFormatter(formatter)

tests/test_log.py

@@ -1,5 +1,7 @@
 import logging
 
+import pytest
+
 from cosmos import get_provider_info
 from cosmos.log import get_logger
 
@@ -14,6 +16,19 @@ def test_get_logger():
     assert custom_logger.handlers[0].formatter.__class__.__name__ == "CustomTTYColoredFormatter"
     assert custom_string in custom_logger.handlers[0].formatter._fmt
 
+    with pytest.raises(TypeError):
+        # Ensure that the get_logger signature is not changed in the future
+        # and name is still a required parameter
+        custom_logger = get_logger()  # noqa
+
+    # Explicitly ensure that even if we pass None or empty string
+    # we will not get root logger in any case
+    custom_logger = get_logger("")
+    assert custom_logger.name != ""
+
+    custom_logger = get_logger(None)  # noqa
+    assert custom_logger.name != ""
+
 
 def test_propagate_logs_conf(monkeypatch):
     monkeypatch.setattr("cosmos.log.propagate_logs", False)