This repository was archived by the owner on May 22, 2025. It is now read-only.
Conversation
- https://github.com/astronomer/astro-sdk/actions/runs/10957200761/job/30424844404\?pr\=2187 - issue that would come after, similar to what we experienced in the Ray Provider and Cosmos projects
…h without GH actions cancelling each other, as seen in https://github.com/astronomer/astro-sdk/actions/runs/10957453565/job/30425642217\?pr\=2188
tatiana
commented
Sep 20, 2024
Collaborator
Author
tatiana
left a comment
tatiana
left a comment
There was a problem hiding this comment.
We need to apply the two recommended commits before merging this PR. They are in place only so we can validate the changes to the CI workflow within this branch.
| on: | ||
| push: | ||
| branches: [ 'main', 'release-**' ] | ||
| branches: [ 'main', 'release-**', 'fix-ci' ] |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| branches: [ 'main', 'release-**', 'fix-ci' ] | |
| branches: [ 'main', 'release-**' ] |
Comment on lines
6
to
7
| - 'python-sdk/**' | ||
| - '.github/workflows/ci-python-sdk.yaml' |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| - 'python-sdk/**' | |
| - '.github/workflows/ci-python-sdk.yaml' | |
| - 'python-sdk/**' | |
| - '.github/workflows/ci-python-sdk.yaml' | |
| pull_request: | |
| branches: [ 'main', 'release-**' ] | |
| paths: | |
| - 'python-sdk/**' | |
| - '.github/workflows/ci-python-sdk.yaml' | |
| - '*' |
pankajkoti
approved these changes
Sep 20, 2024
tatiana
commented
Sep 20, 2024
| include-hidden-files: true | ||
|
|
||
| Code-Coverage: | ||
| if: github.event.action != 'labeled' |
Collaborator
Author
There was a problem hiding this comment.
I just noticed some tests failed due to uploading artefacts with the same name; this has to be addressed before we merge this PR. This project thas not been actively maintained for a while, so we may uncover other issues before this PR can be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CI issues, as experienced in https://github.com/astronomer/astro-sdk/actions/runs/10957200761/job/30424844404\?pr\=2187
This PR also fixes the issue that would come after, similar to what we experienced in the Ray Provider and Cosmos projects.