Stop catching generic Exception in triggerer #98
Merged
Conversation
tatiana
commented
Nov 28, 2024
tatiana
commented
Nov 28, 2024
tatiana
commented
Nov 28, 2024
tatiana
commented
Nov 28, 2024
tatiana
commented
Nov 28, 2024
tatiana
commented
Nov 28, 2024
pankajastro
approved these changes
Nov 28, 2024
Contributor
pankajastro
left a comment
pankajastro
left a comment
There was a problem hiding this comment.
just have a minor question otherwise looking good
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
- Coverage 98.22% 97.74% -0.49%
==========================================
Files 5 6 +1
Lines 564 576 +12
==========================================
+ Hits 554 563 +9
- Misses 10 13 +3 ☔ View full report in Codecov by Sentry. |
By catching `Exception`, we run into the ristk of hitting an unexpected exception that the program can't recover from, or worse, swallowing an important exception without properly logging it - a huge headache when trying to debug programs that are failing in weird ways This was identified during #81 development.
tatiana
force-pushed
the
issue-81-remove-exceptions
branch
from
4c6a4a5 to
2d7cdc2
Compare
pankajastro
approved these changes
Nov 28, 2024
This was referenced Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By catching
Exception, we risk hitting an unexpected exception that the program can't recover from, or worse, swallowing an important exception without properly logging it - a massive headache when trying to debug programs that are failing in weird ways.If this change leads to any exceptions that should be caught being raised, we'll have the opportunity to understand which are those exceptions and capture them, handling them in a graceful way.
This was identified during #81 development.