Attempt CI fix wrt broken coverage upload artifact#49
Merged
Conversation
venkatajagannath
temporarily deployed
to
internal
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
=======================================
Coverage 96.41% 96.41%
=======================================
Files 4 4
Lines 279 279
=======================================
Hits 269 269
Misses 10 10 ☔ View full report in Codecov by Sentry. |
pankajkoti
approved these changes
Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently the GitHub action https://github.com/actions/upload-artifact released a breaking change actions/upload-artifact#602 (not following semver guidelines) which is affecting our CodeCov job as it's no longer
able to download artifacts that were supposed to be uploaded from our tests in earlier jobs in the CI.
According to suggestion in https://github.com/actions/upload-artifact/pull/607/files, set include include-hidden-files: true, so that our workflow continues to work as it was before.
Similar to fix in: astronomer/astro-provider-ray#60