Regex update to avoid over-redaction of GitHub issues #325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello - this PR adjusts the regexes found in
airflow/include/tasks/extract/github.py
that remove boilerplate text from GitHub issue thread text. Before this change, the regular expressions will remove too much text due to the greedy matching.Consider the following example:
The two lines containing comments should be removed, but the greedy match in the regular expression
<!--\r\nThank you.*?http://chris.beams.io/posts/git-commit/\r\n-->
will cause the lineMore discussion here.
to be removed as well.To fix that behavior, this PR replaces each greedy
.*
sequence with a lazy.*?
sequence so that the minimum (intended) match is removed.