Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Firestore Metric Field Name to Load into Snowflake #321

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Change Firestore Metric Field Name to Load into Snowflake #321

merged 1 commit into from
Mar 19, 2024

Conversation

davidgxue
Copy link
Contributor

Description

  • response_received_at is a nullable field. Specifically, if a request errored out, then this field is null.
  • Changing to put sent_at field into snowflake's created_at column instead

Tests

  • Tested manually on dev server
image Verified in snowflake image

@davidgxue davidgxue self-assigned this Mar 19, 2024
@davidgxue davidgxue merged commit 20ef1c7 into main Mar 19, 2024
8 checks passed
@davidgxue davidgxue deleted the 0.3.2-bugfix-snowflake-metric-name branch March 19, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaneve jlaneve jlaneve approved these changes

@Lee-W Lee-W Awaiting requested review from Lee-W Lee-W is a code owner

@pankajastro pankajastro Awaiting requested review from pankajastro pankajastro is a code owner

@sunank200 sunank200 Awaiting requested review from sunank200 sunank200 is a code owner

Assignees

@davidgxue davidgxue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidgxue @jlaneve