clean html extractor #237
Merged
clean html extractor #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
f0967a6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2bdc6694.ask-astro.pages.dev |
| Branch Preview URL: | https://reuse-html.ask-astro.pages.dev |
|
currently, retry for HTTP call is missing here as we have in airflow/include/tasks/extract/utils/html_helpers.py. I was thing to do it in separate PR |
Lee-W
reviewed
Jan 3, 2024
Lee-W
reviewed
Jan 4, 2024
sunank200
requested changes
Jan 5, 2024
There was a problem hiding this comment.
@pankajastro Can you run this again with new weaviate provider by deleting the weaviate index and reingesting, please?
The code in main branch uses latest weaviate provider. You might want to rebase and re-run the DAG after deleting the weaviate index. First you need to run bulk ingest then you need to run other DAGs.
pankajastro
force-pushed
the
reuse_html
branch
2 times, most recently
from
203a61d to
8c65471
Compare
|
@pankajastro tested this only observation was that source count has increased, however, as discussed with @sunank200 this was related to PR, we should be ok to close this |
pankajastro
force-pushed
the
reuse_html
branch
from
b518821 to
7780e21
Compare
sunank200
approved these changes
Jan 11, 2024
sunank200
pushed a commit
that referenced
this pull request
Jan 16, 2024
closes: #164 Currently, We have some duplicate code in the HTML extractor, this PR aims to remove the duplicate code and reuse it from html_utils.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #164
Currently, We have some duplicate code in the HTML extractor, this PR aims to remove the duplicate code and reuse it from html_utils.