-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a cutoff date for GitHub issue #229
Conversation
Recently, we started getting zombie job and I feel this because of lot of data on worker
@@ -203,7 +204,7 @@ def extract_github_issues(repo_base: str, github_conn_id: str) -> pd.DataFrame: | |||
gh_hook = GithubHook(github_conn_id) | |||
|
|||
repo = gh_hook.client.get_repo(repo_base) | |||
issues = repo.get_issues(state="all") | |||
issues = repo.get_issues(state="all", since=datetime(2022, 1, 1)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This date should be environment variable or something that can be configured from UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could make the cuteoff date configurable, but not a blocker to this PR
Deploying with Cloudflare Pages
|
closes: #227
Recently, we started getting zombie job and I feel this because of lot of data on worker