-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Astro forum docs #212
Add Astro forum docs #212
Conversation
Deploying with Cloudflare Pages
|
@vatsrahul1001 We need to test this PR too. please let me know when you are planning to test I'll keep ready db accordingly |
bcac955
to
5eb1caf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets ingest data to a separate weaviate index and test this out. cc: @pankajastro @vatsrahul1001
default_args=default_args, | ||
) | ||
def ask_astro_load_astro_forum(): | ||
_import_data = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should ideally be in three tasks right?
extract_forum_docs >> split_docs >> ingest_data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ingestion for this docs take around 1min so splitting won't add much value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or this is a requirement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a reference implementation. It's good to keep different tasks broken down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
splited it. PTAL
@pankajastro let me know when index is pointed to dev |
9bbe0ff
to
2fd60ef
Compare
closes: #120