-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate Ask Astro QA #210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look like some CI jobs has not ran on this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add the documentation around how one should run this as well. Also, we should add environment variable details if required.
The pre-commit should be changed to run on this PR as well.
Co-authored-by: Pankaj Singh <[email protected]>
Co-authored-by: Pankaj Singh <[email protected]>
Co-authored-by: Ankit Chaurasia <[email protected]>
Co-authored-by: Ankit Chaurasia <[email protected]>
Co-authored-by: Ankit Chaurasia <[email protected]>
Co-authored-by: Ankit Chaurasia <[email protected]>
Co-authored-by: Ankit Chaurasia <[email protected]>
Co-authored-by: Ankit Chaurasia <[email protected]>
Co-authored-by: Wei Lee <[email protected]>
Co-authored-by: Wei Lee <[email protected]>
Co-authored-by: Wei Lee <[email protected]>
Co-authored-by: Wei Lee <[email protected]>
Co-authored-by: Wei Lee <[email protected]>
Co-authored-by: Wei Lee <[email protected]>
Co-authored-by: Wei Lee <[email protected]>
@sunank200 I have tested PR and able to generate results, we should be fine to merge this PR |
@vatsrahul1001, could you please update the PR title and description? Let's also review the doc-string details in the DAG as discussed during the call. |
verified docs string in DAG looks fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vatsrahul1001 LGTM.
Thank you for taking care of this.
@vatsrahul1001 lets connect with @davidgxue and make sure relevant issues are created for further changes based on retrevial in recent PR.
This PR addresses automation of the QA process for Ask Astro, User can provide a list of questionnaires as a gsheet and run the
test_retrieval
DAG, Result sheet will be generated by the DAG at respective env foldercloses: #143