Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate Ask Astro QA #210

Merged
merged 23 commits into from
Jan 10, 2024
Merged

Automate Ask Astro QA #210

merged 23 commits into from
Jan 10, 2024

Conversation

mpgreg
Copy link
Contributor

@mpgreg mpgreg commented Dec 14, 2023

This PR addresses automation of the QA process for Ask Astro, User can provide a list of questionnaires as a gsheet and run the test_retrieval DAG, Result sheet will be generated by the DAG at respective env folder

closes: #143

@mpgreg mpgreg marked this pull request as ready for review December 15, 2023 18:19
Copy link
Collaborator

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like some CI jobs has not ran on this PR

airflow/dags/monitor/test_retrieval.py Outdated Show resolved Hide resolved
airflow/dags/monitor/test_retrieval.py Outdated Show resolved Hide resolved
airflow/dags/monitor/test_retrieval.py Outdated Show resolved Hide resolved
airflow/dags/monitor/test_retrieval.py Show resolved Hide resolved
Copy link
Collaborator

@sunank200 sunank200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the documentation around how one should run this as well. Also, we should add environment variable details if required.

The pre-commit should be changed to run on this PR as well.

airflow/dags/monitor/test_retrieval.py Show resolved Hide resolved
airflow/dags/monitor/test_retrieval.py Show resolved Hide resolved
airflow/dags/monitor/test_retrieval.py Outdated Show resolved Hide resolved
airflow/dags/monitor/test_retrieval.py Show resolved Hide resolved
airflow/include/tasks/extract/utils/retrieval_tests.py Outdated Show resolved Hide resolved
airflow/include/tasks/extract/utils/retrieval_tests.py Outdated Show resolved Hide resolved
airflow/include/tasks/extract/utils/retrieval_tests.py Outdated Show resolved Hide resolved
airflow/include/tasks/extract/utils/retrieval_tests.py Outdated Show resolved Hide resolved
airflow/include/tasks/extract/utils/retrieval_tests.py Outdated Show resolved Hide resolved
@mpgreg mpgreg self-assigned this Dec 18, 2023
airflow/dags/monitor/test_retrieval.py Outdated Show resolved Hide resolved
airflow/dags/monitor/test_retrieval.py Outdated Show resolved Hide resolved
airflow/dags/monitor/test_retrieval.py Outdated Show resolved Hide resolved
airflow/dags/monitor/test_retrieval.py Outdated Show resolved Hide resolved
airflow/dags/monitor/test_retrieval.py Outdated Show resolved Hide resolved
airflow/include/tasks/extract/utils/retrieval_tests.py Outdated Show resolved Hide resolved
airflow/include/tasks/extract/utils/retrieval_tests.py Outdated Show resolved Hide resolved
airflow/include/tasks/extract/utils/retrieval_tests.py Outdated Show resolved Hide resolved
@vatsrahul1001
Copy link
Collaborator

@sunank200 I have tested PR and able to generate results, we should be fine to merge this PR

@sunank200
Copy link
Collaborator

@sunank200 I have tested PR and able to generate results, we should be fine to merge this PR

@vatsrahul1001, could you please update the PR title and description? Let's also review the doc-string details in the DAG as discussed during the call.

@vatsrahul1001 vatsrahul1001 changed the title fixes #143 Automate Ask Astro QA Jan 9, 2024
@vatsrahul1001
Copy link
Collaborator

@sunank200 I have tested PR and able to generate results, we should be fine to merge this PR

@vatsrahul1001, could you please update the PR title and description? Let's also review the doc-string details in the DAG as discussed during the call.

verified docs string in DAG looks fine

Copy link
Collaborator

@sunank200 sunank200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vatsrahul1001 LGTM.

Thank you for taking care of this.

@vatsrahul1001 lets connect with @davidgxue and make sure relevant issues are created for further changes based on retrevial in recent PR.

@vatsrahul1001 vatsrahul1001 merged commit 35b9823 into astronomer:main Jan 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate the test plan to run via script based on test plan
5 participants