Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check possibility for throttling Ask Astro requests #230

Closed
pankajkoti opened this issue Dec 22, 2023 · 2 comments · Fixed by #235
Closed

Check possibility for throttling Ask Astro requests #230

pankajkoti opened this issue Dec 22, 2023 · 2 comments · Fixed by #235
Assignees
@pankajkoti

Comments

@pankajkoti
Copy link
Contributor

Context: https://astronomer.slack.com/archives/C05QJA9LTR9/p1703159886303619

Check the possibility of throttling repeated requests coming from the same user in a stipulated amount time.
@pankajkoti pankajkoti self-assigned this Dec 22, 2023
This was referenced Dec 22, 2023
Closed
Merged
pankajkoti added a commit that referenced this issue Dec 26, 2023
@pankajkoti
Use sanic-limiter to throttle api requests
36ae525 
closes: #230
@pankajkoti pankajkoti mentioned this issue Dec 26, 2023
Merged
@pankajkoti
Copy link
Contributor Author

pankajkoti commented Dec 26, 2023 •
edited
Loading

Created PR: #235

@pankajkoti
Copy link
Contributor Author

pankajkoti commented Dec 27, 2023 •
edited
Loading

I have addressed the review comments received so far on the PR. PR is waiting for reviews/approval.

pankajkoti added a commit that referenced this issue Dec 27, 2023
@pankajkoti @sunank200
Use sanic-limiter to throttle api requests (#235)
935ee41 
Throttles API requests based on user's IP address. 
With this PR, at the moment, we are only throttling `/requests`
endpoint.

closes: #230

---------

Co-authored-by: Ankit Chaurasia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pankajkoti pankajkoti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use sanic-limiter to throttle api requests astronomer/ask-astro
1 participant
@pankajkoti