Simplify example path manipulation with pathlib

[Kilo59]

Don't need to use both os.path and pathlib.Path

https://treyhunner.com/2019/01/no-really-pathlib-is-great/

I need to double check that great_expectation data_context_root_dir actually can take a pathlib.Path object.
If it doesn't it definitely should 😄 .

[denimalpaca]

@Kilo59 Did you ever get a chance to double check that?

[Kilo59]

@denimalpaca
So we actually don't currently accept a pathlib.Path but we will soon 😅

great-expectations/great_expectations#6613

[Kilo59]

@denimalpaca
With the latest release, we do finally accept a pathlib.Path object.
https://github.com/great-expectations/great_expectations/releases/tag/0.15.42

But given that it's so recent it might be better to make this example work on earlier releases.
I'll update this to call str() as the final step to ensure maximum compatibility.

[denimalpaca]

Happy to review and merge when you make that change!

[denimalpaca]

Let me know when that string call is added and I'm happy to approve!

[denimalpaca]

Not entirely sure how base_path works, but are there not +'s missing here?

[Kilo59]

No. The / operator can be used to join paths.

https://docs.python.org/3/library/pathlib.html#operators

So the following will all produce the same path object. As long as the first item is a Path object.

ge_root_dir = base_path / "include" / "great_expectations"
ge_root_dir = base_path.joinpath("include" , "great_expectations")
ge_root_dir = Path(base_path, "include" , "great_expectations")

[Kilo59]

@denimalpaca updated.
Also here's another good article explaining pathlib

https://realpython.com/python-pathlib

[denimalpaca]

Thanks for the links, looking into that.