Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded great-expectations>=0.15.34 and sqlalchemy>=1.4.44 #65

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

zhangchi1
Copy link
Contributor

@zhangchi1 zhangchi1 commented Nov 23, 2022

Upgrade great_expectation py lib version

Hi @denimalpaca, I realized that our operator is installing great-expectations 0.13.x (published on 3/17/2021) and the latest great-expectations 0.15.x has a lot of updates and bug fixes.
I believe some issues related to data_asset_name can be resolved if we keep with the latest version of great-expectations
Reference: great-expectations/great_expectations#6260

Let me know if you have any opinions and feel free to let me know what is our best practice for adding test cases.

Look forward to hearing back from you.

Thanks,

setup.py Outdated
Comment on lines 20 to 21
"great-expectations>=0.15.34",
"sqlalchemy>=1.4.44",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. I think we should probably pin with an == for good measure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @denimalpaca , sorry that I just saw your comment. Updated the install_requires with ==. Btw, do we have auto-squash commits setup in our PR? Or I need to do it on my local? Thank you again ~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhangchi1 You need to rebase on main now, we just changed setup.py to setup.cfg. Auto-squash commits are enabled. I'm just doing a little local test on the req updates then I'll approve and @kaxil or I can squash and merge after you rebase. Thank you for contributing!

Copy link
Contributor Author

@zhangchi1 zhangchi1 Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @denimalpaca just rebased, leave it with just 1 commit. Let me know if everything looks good to you ~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry about suggesting the == pinning, didn't realize it would potentially cause problems!

@zhangchi1 zhangchi1 force-pushed the upgrade/version-upgrade-require-libs branch from 32ce1a4 to 153b626 Compare November 23, 2022 19:13
setup.cfg Outdated Show resolved Hide resolved
Co-authored-by: Kaxil Naik <[email protected]>
@zhangchi1
Copy link
Contributor Author

hi @kaxil I saw the pipeline is running, let me know if we still need a squash?

@kaxil kaxil merged commit 1ae4965 into astronomer:main Nov 23, 2022
@kaxil
Copy link
Collaborator

kaxil commented Nov 23, 2022

hi @kaxil I saw the pipeline is running, let me know if we still need a squash?

All good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants