Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix template extension bug #64

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Fix template extension bug #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions great_expectations_provider/operators/great_expectations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,9 @@ class GreatExpectationsOperator(BaseOperator):
"data_context_root_dir",
"checkpoint_name",
"checkpoint_kwargs",
"query_to_validate"
"query_to_validate",
)
template_ext = (".sql")
template_ext = (".sql",)
operator_extra_links = (GreatExpectationsDataDocsLink(),)

def __init__(
Expand Down
3 changes: 2 additions & 1 deletion tests/operators/test_great_expectations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,8 @@ def test_great_expectations_operator__assert_template_ext_exist():
data_context_root_dir=ge_root_dir,
checkpoint_name="taxi.pass.chk",
)
assert ".sql" in operator.template_ext
for ext in operator.template_ext:
assert ext == ".sql"


def test_great_expectations_operator__context_root_dir_and_checkpoint_name_pass():
Expand Down