Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create_temp_table support #129

Conversation

antelmoa
Copy link
Contributor

@antelmoa antelmoa commented Feb 1, 2024

Allows users to configure create_temp_table by using the extra field in the connection form. The value of create_temp_table is true by default and, by setting it to false, it bypasses the creation of temporary tables from Great Expectations. Which is necessary when one only has read access to a database.

Usage:
In the extras field do the following:

{
"create_temp_table": false
}

@antelmoa antelmoa changed the title astronmer#112: add create_temp_table support astronomer#112: add create_temp_table support Feb 1, 2024
@antelmoa antelmoa force-pushed the astronomer-#112-add-create-temp-table-config-support branch from 14c1930 to 43cbb6f Compare February 1, 2024 16:08
Copy link
Contributor

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks great! Left one minor suggestion

@Lee-W Lee-W changed the title astronomer#112: add create_temp_table support add create_temp_table support Feb 2, 2024
@Lee-W
Copy link
Contributor

Lee-W commented Feb 2, 2024

closes: #112

Copy link
Contributor

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antelmoa
Copy link
Contributor Author

antelmoa commented Feb 2, 2024

Thanks for pushing this along! May I know when I can expect this to be merged and released, please? Thank you!

@pankajastro pankajastro merged commit 635314e into astronomer:main Feb 2, 2024
6 checks passed
@pankajastro
Copy link
Contributor

Thanks for pushing this along! May I know when I can expect this to be merged and released, please? Thank you!

We will probably release it early next week.

@antelmoa
Copy link
Contributor Author

antelmoa commented Feb 2, 2024

That is awesome! Thank you!

@pankajastro pankajastro changed the title add create_temp_table support Add create_temp_table support Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants