-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add create_temp_table support #129
Add create_temp_table support #129
Conversation
14c1930
to
43cbb6f
Compare
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks great! Left one minor suggestion
closes: #112 |
Co-authored-by: Wei Lee <[email protected]>
Co-authored-by: Wei Lee <[email protected]>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for pushing this along! May I know when I can expect this to be merged and released, please? Thank you! |
We will probably release it early next week. |
That is awesome! Thank you! |
Allows users to configure
create_temp_table
by using theextra
field in the connection form. The value ofcreate_temp_table
istrue
by default and, by setting it tofalse
, it bypasses the creation of temporary tables from Great Expectations. Which is necessary when one only has read access to a database.Usage:
In the
extras
field do the following:{
"create_temp_table": false
}