Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snowflake Region Should be Optional #101

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Snowflake Region Should be Optional #101

merged 2 commits into from
Mar 20, 2023

Conversation

mpgreg
Copy link
Contributor

@mpgreg mpgreg commented Mar 20, 2023 •
edited by denimalpaca
Loading

closes #100

@mpgreg mpgreg requested a review from denimalpaca March 20, 2023 14:52
denimalpaca
denimalpaca approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@denimalpaca denimalpaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, could you just rebase this on the latest main? there was a pretty big change to the Snowflake connection last week

@mpgreg
Copy link
Contributor Author

mpgreg commented Mar 20, 2023

Hmmm I thought I had done that. Is it not showing properly?

@denimalpaca denimalpaca changed the title fixes #100 Snowflake Region Should be Optional Mar 20, 2023
@denimalpaca denimalpaca merged commit e2426cc into astronomer:main Mar 20, 2023
@denimalpaca
Copy link
Contributor

@mpgreg you were right, I just didn't look closely enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denimalpaca denimalpaca denimalpaca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snowflake Region should be optional
2 participants
@mpgreg @denimalpaca