Skip to content

Commit

Permalink
Bugfix: Remove unnecessary ValueError (#82)
Browse files Browse the repository at this point in the history
An extraneous ValueError was in build_runtime_datasources and caused
incorrect operator failure when a runtime datasource is built but
a connection or dataframe is not passed in. The if/elif/else block
would hit the else, which was a ValueError, and it made the below
if statement on checkpoint_kwargs unreachable. It has been removed
as the ValueError in the first if block is sufficient to halt
operator execution in the case of incorrect usage.
  • Loading branch information
denimalpaca authored Jan 6, 2023
1 parent f33560e commit 8b00e7f
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions great_expectations_provider/operators/great_expectations.py
Original file line number Diff line number Diff line change
Expand Up @@ -367,8 +367,6 @@ def build_runtime_datasources(self):
batch_request = self.build_configured_sql_datasource_batch_request()
else:
raise ValueError("Unrecognized, or lack of, runtime query or Airflow connection passed.")
else:
raise ValueError("Unrecognized, or lack of, runtime or conn_id datasource passed.")
if not self.checkpoint_kwargs:
self.batch_request = batch_request

Expand Down

0 comments on commit 8b00e7f

Please sign in to comment.