Skip to content

feat: Trusted Auctioneer: add event which is triggered when the mempool is cleared #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bharath-123 merged 80 commits into from
Jan 13, 2025
Merged

feat: Trusted Auctioneer: add event which is triggered when the mempool is cleared #9

bharath-123 merged 80 commits into from
Jan 13, 2025

Conversation

@bharath-123
Copy link
Contributor

@bharath-123 bharath-123 commented Sep 26, 2024 •
edited
Loading

This PR adds an event.feed to the legacy pool to which an event is sent after the mempool is cleared after a reset.

Changes made:

  1. Add mempoolClearedFeed to legacy pool
  2. Send event to this feed after mempool is cleared in clearPendingAndQueued
  3. Add unit tests

@bharath-123 bharath-123 force-pushed the bharath/add-mempool-clearing-event branch from 67e8bb3 to 7428c4f Compare September 27, 2024 10:30
@bharath-123 bharath-123 force-pushed the bharath/add-mempool-clearing-event branch from 7428c4f to 14d50b2 Compare September 27, 2024 11:06
@bharath-123 bharath-123 changed the title feat: add event which is triggered when the mempool is cleared feat: Trusted Auctioneer: add event which is triggered when the mempool is cleared Sep 30, 2024
@bharath-123 bharath-123 force-pushed the bharath/add-mempool-clearing-event branch from 14d50b2 to 9d5e8a9 Compare September 30, 2024 18:09
@bharath-123 bharath-123 marked this pull request as ready for review October 1, 2024 18:11
@bharath-123 bharath-123 force-pushed the bharath/clear-mempool branch from 9b4fc78 to 31aa2f0 Compare October 16, 2024 11:27
@bharath-123 bharath-123 force-pushed the bharath/add-mempool-clearing-event branch 2 times, most recently from c39ff65 to f13364b Compare October 16, 2024 17:53
@bharath-123 bharath-123 force-pushed the bharath/add-mempool-clearing-event branch from f13364b to 0be6ac1 Compare October 24, 2024 06:43
@bharath-123 bharath-123 force-pushed the bharath/clear-mempool branch from d623d80 to bcac6c2 Compare October 24, 2024 08:49
@bharath-123 bharath-123 force-pushed the bharath/add-mempool-clearing-event branch from 0be6ac1 to 59f90a7 Compare October 24, 2024 08:50
@bharath-123 bharath-123 force-pushed the bharath/clear-mempool branch from bcac6c2 to 64907bb Compare October 24, 2024 15:23
@bharath-123 bharath-123 force-pushed the bharath/add-mempool-clearing-event branch from 59f90a7 to 5d40100 Compare October 24, 2024 15:24
@bharath-123 bharath-123 force-pushed the bharath/clear-mempool branch from 64907bb to 4d59dca Compare October 29, 2024 08:11
@bharath-123 bharath-123 force-pushed the bharath/add-mempool-clearing-event branch from 5d40100 to 40652a0 Compare October 29, 2024 08:17
bharath-123
bharath-123 commented Nov 5, 2024
View reviewed changes
core/txpool/legacypool/legacypool.go Outdated
Comment on lines 1797 to 1800
pool.mempoolClearFeed.Send(core.NewMempoolCleared{
NewHead: newHead,
})

Copy link
Contributor Author

@bharath-123 bharath-123 Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be at the end of runReorg so that this doesn't run with the pool mutex lock held.

@bharath-123 bharath-123 force-pushed the bharath/add-mempool-clearing-event branch from 15d4ce4 to e7abf02 Compare November 10, 2024 09:09
@bharath-123 bharath-123 force-pushed the bharath/clear-mempool branch from 664fc48 to d9484cc Compare November 12, 2024 08:44
@bharath-123 bharath-123 force-pushed the bharath/add-mempool-clearing-event branch from e7abf02 to 0158846 Compare November 12, 2024 08:45
@bharath-123 bharath-123 force-pushed the bharath/clear-mempool branch from d9484cc to af14e44 Compare November 20, 2024 06:53
@bharath-123 bharath-123 force-pushed the bharath/add-mempool-clearing-event branch from 0158846 to fd3dd2c Compare November 20, 2024 06:54
@bharath-123 bharath-123 force-pushed the bharath/clear-mempool branch from af14e44 to 23244aa Compare January 9, 2025 09:55
@bharath-123 bharath-123 force-pushed the bharath/add-mempool-clearing-event branch from fd3dd2c to 99acf19 Compare January 9, 2025 09:55
@bharath-123 bharath-123 force-pushed the bharath/clear-mempool branch from 23244aa to 01be512 Compare January 13, 2025 17:47
@bharath-123
update protos
f4bc725
@bharath-123
change trusted builder instances to auctioneer
2992b5b
@bharath-123
fix typo
a82a00e
@bharath-123
add an api to query the optimistic block
9809d0c
@bharath-123
support querying optimistic block using the optimistic string
e6f1345
@bharath-123
close the stream when we get the done signal
2561dc3
@bharath-123
add debug logs for when the stream rpcs are called
df8ead5
@bharath-123
add some logs
7aed2a0
@bharath-123
add some logs
634e962
@bharath-123
use atomic pointer for fee recipient
e5d90d2
@bharath-123
remove unecessary lock
9e7abe7
@bharath-123
wrap errors
f7d5584
@bharath-123
buffer the reserved addresses and remove them at once
1457ce3
@bharath-123
avoid cleaning up duplicate addresses
b6e5401
@bharath-123
add metrics
1cd5701
@bharath-123
update depot token
b555cc9
@bharath-123
add a few debug logs
3284998
@bharath-123
update to use new protos
17dbebd
@bharath-123
update protobufs
1c1a935
@bharath-123
Merge pull request #28 from astriaorg/bharath/update-protos
5b99a85 
chore: Trusted Auctioneer: update the protos
@bharath-123
Merge pull request #25 from astriaorg/bharath/add-auctioneer-metrics
d5628b5 
feat: Trusted Auctioneer: Add initial set of metrics for auctioneer
@bharath-123
Merge pull request #24 from astriaorg/bharath/code-cleanups
e49d7f4 
feat: Trusted Auctioneer: Code cleanups
@bharath-123
Merge pull request #22 from astriaorg/bharath/api-to-query-optimistic…
98e817c 
…-block

feat: Trusted Auctioneer: Add API to query the current optimistic block
@bharath-123
Merge pull request #21 from astriaorg/bharath/auction-result
2b9a863 
feat: Trusted Auctioneer: Support unmarshalling signed allocations and placing it at the TOB
@bharath-123
Merge pull request #17 from astriaorg/bharath/feature-flag-auctioneer
e384e18 
feat: Trusted Auctioneer: Add a cmd line flag to run a Flame node in auctioneer mode
@bharath-123
Merge pull request #16 from astriaorg/bharath/refactor-services
9a7f5ad 
refactor: Trusted Auctioneer: Separate execution api service and optimistic execution api service
@bharath-123
Merge pull request #12 from astriaorg/bharath/implement-bundle-streaming
43fdcea 
feat: Trusted Auctioneer: Implement bundle streaming
@bharath-123
Merge pull request #11 from astriaorg/bharath/implement-optimistic-ex…
9496cb9 
…ecution

feat: Trusted Auctioneer: implement stream execute optimistic block
@bharath-123 bharath-123 merged commit 41fb511 into bharath/clear-mempool Jan 13, 2025
@bharath-123 bharath-123 mentioned this pull request Jan 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joroshiba joroshiba Awaiting requested review from joroshiba joroshiba is a code owner

@mycodecrafting mycodecrafting Awaiting requested review from mycodecrafting

@noot noot Awaiting requested review from noot

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bharath-123