fix: Auctioneer: multiply effective tip with gas used by tx while streaming bid #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharath-123
requested review from
joroshiba,
mycodecrafting and
noot
as code owners
joroshiba
approved these changes
Jan 14, 2025
grpc/optimistic/server.go
Outdated
Comment on lines
77
to
78
| totalTipFee := big.NewInt(0).Mul(effectiveTip, big.NewInt(int64(gasUsed))) | ||
| totalCost.Add(totalCost, totalTipFee) |
Member
There was a problem hiding this comment.
Suggested change
| totalTipFee := big.NewInt(0).Mul(effectiveTip, big.NewInt(int64(gasUsed))) | |
| totalCost.Add(totalCost, totalTipFee) | |
| totalCost = totalCost.Mul(effectiveTip, big.NewInt(int64(gasUsed))) |
Merged
bharath-123
pushed a commit
that referenced
this pull request
Mar 10, 2025
## Summary Adds a precompile manager that makes it easy to add new precompiles to the evm by writing an implementation in go which corresponds to a defined solidity interface. These precompiles can optionally have state in the evm state db. ## Background This updates a PR from the old astria `go-ethereum` repo to the latest changes in the newer `astria-geth` repo. The precompile manager is heavily utilized by Forma and potentially useful for other custom evm rollups. @itamarreif may have some ideas of things he might like to do with it. There are no custom precompiles enabled by default. ## Changes from old PR * Custom gas handler per precompile method * Better configuration of which precompiles are enabled * Removal of native minter as an example precompile; and addition of an example base64 precompile which is simpler to understand and potentially more useful for rollup devs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we stream a bid, we also send the tip fee of the bid. Currently we were sending the
effective tip per gas. We should be multiplying it with the gas used by the tx.This PR also includes a minor cosmetic change where we display the sequencer hash in the debug log called at the start of the
ExecuteOptimisticBlockas acommon.Hashrather than a byte array.