chore(sequencer): init allowed assets in fees component#1730
Merged
SuperFluffy merged 2 commits intomainfrom Oct 24, 2024
Merged
chore(sequencer): init allowed assets in fees component#1730SuperFluffy merged 2 commits intomainfrom
SuperFluffy merged 2 commits intomainfrom
Conversation
Base automatically changed from
superfluffy/soft-remove-of-native-assets
to
main
October 23, 2024 21:50
Fraser999
approved these changes
Oct 24, 2024
SuperFluffy
force-pushed
the
superfluffy/set-allowed-fee-asset-in-fee-init-chain
branch
from
0656b56 to
c5d336f
Compare
Fraser999
approved these changes
Oct 24, 2024
SuperFluffy
deleted the
superfluffy/set-allowed-fee-asset-in-fee-init-chain
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the initialization of allowed assets from the overall app to the fees component.
Background
#1647 moved fee asset state handling to the new
feescomponent. It was overlooked that writing allowed fee assets should also happen in its init chain logic.Changes
Testing
Nothing has changed in terms of how the state is represented. Tests that rely on init chain still work.
Breaking Changelist
This is not a breaking change because the state after this change looks the same.