refactor(sequencer): remove unused asset storage variant#1704
Merged
SuperFluffy merged 2 commits intomainfrom Oct 21, 2024
Merged
refactor(sequencer): remove unused asset storage variant#1704SuperFluffy merged 2 commits intomainfrom
SuperFluffy merged 2 commits intomainfrom
Conversation
SuperFluffy
changed the title
Fraser999
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes an unused variant of the internal storage implementation of sequencer asset component.t
Background
As part of #1647 fees were moved from the assets to the fees component. The present variant was overlooked.
Changes
Testing
Not applicable. Dead code.
Breaking Changelist
This is not a breaking change because a) the variant was never used (there was not even a theoretic way to write it after #1647) and b) no variants existed after the variant. If they had, this change would lead to a shift in the variants, causing breakage.