feat(sequencer): make fees optional at genesis#1664
Merged
ethanoroshiba merged 5 commits intomainfrom Oct 23, 2024
Merged
Conversation
SuperFluffy
approved these changes
Oct 18, 2024
Contributor
SuperFluffy
left a comment
SuperFluffy
left a comment
There was a problem hiding this comment.
Changes look good and are fine to be merged IMO.
It looks like we can only ever enable certain actions via their fees, but never disable them. Going to bring this up with the team.
joroshiba
approved these changes
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Made all fees except for
FeeChangeaction optional at genesis.Background
Tracking PR for this comment. Allows for more flexibility at genesis. Post #1647, an action with no fees in the state is by default deactivated until it is explicitly given fees, even if they are 0. This is to allow for actions to be added in the future without breaking consensus, but also allows for more flexibility at genesis. Now, all actions can be disabled at genesis by making the fees optional, except for
FeeChange, which is needed in order to activate actions by giving them fees.Changes
GenesisFeesoptional (except for fee_change).Testing
Passing all tests.
Related Issues
closes #1662