Closed
Conversation
sambukowski
reviewed
Oct 9, 2024
| inner: ArgsInner, | ||
| } | ||
|
|
||
| impl SequenceByteCostMul { |
Contributor
There was a problem hiding this comment.
I think it would be better to type out the whole name for this type. SequenceByteCostMultiplier
sambukowski
reviewed
Oct 9, 2024
| } | ||
|
|
||
| #[derive(Clone, Debug, clap::Args)] | ||
| struct BridgeLockByteCostMul { |
sambukowski
reviewed
Oct 9, 2024
| inner: ArgsInner, | ||
| } | ||
|
|
||
| impl BridgeLockByteCostMul { |
sambukowski
approved these changes
Oct 9, 2024
Contributor
sambukowski
left a comment
sambukowski
left a comment
There was a problem hiding this comment.
LGTM. Just nits on struct naming.
quasystaty1
force-pushed
the
quasystaty1/ENG-901/cli/change-fee-command
branch
from
f447a92 to
b26657f
Compare
Contributor
ethanoroshiba
left a comment
ethanoroshiba
left a comment
There was a problem hiding this comment.
Aside from some typos, LGTM.
| SubCommand::BridgeUnlockFee(bridge_unlock) => bridge_unlock.run().await, | ||
| SubCommand::BridgeSudoChangeFee(bridge_sudo_change) => bridge_sudo_change.run().await, | ||
| SubCommand::Ics20WithdrawalFee(ics20_withdrawal) => ics20_withdrawal.run().await, | ||
| SubCommand::IbcRelaeyFee(ibc_relay) => ibc_relay.run().await, |
Contributor
There was a problem hiding this comment.
Suggested change
| SubCommand::IbcRelaeyFee(ibc_relay) => ibc_relay.run().await, | |
| SubCommand::IbcRelayFee(ibc_relay) => ibc_relay.run().await, |
| #[allow(clippy::enum_variant_names)] | ||
| #[derive(Debug, Subcommand)] | ||
| enum SubCommand { | ||
| /// Chnage Transfer Fee |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Chnage Transfer Fee | |
| /// Change Transfer Fee |
| TransferFee(Transfer), | ||
| /// Change Init Bridge Account Fee | ||
| InitBridgeFee(BridgeInit), | ||
| /// Change Sequence Fee |
Contributor
There was a problem hiding this comment.
Would it be better to call this Rollup Data Submission Fee? I'm not opinionated either way, but maybe worth considering.
| /// Change ICS20 Withdrawal Fee | ||
| Ics20WithdrawalFee(Ics20Withdrawal), | ||
| /// Change IBC Relay Fee | ||
| IbcRelaeyFee(IbcRelay), |
Contributor
There was a problem hiding this comment.
Suggested change
| IbcRelaeyFee(IbcRelay), | |
| IbcRelayFee(IbcRelay), |
quasystaty1
force-pushed
the
quasystaty1/ENG-901/cli/change-fee-command
branch
from
2111b0d to
a3cec30
Compare
Member
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or this PR will be |
Member
|
This PR was closed because it has been stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
FeeChangeActionto the cli as a sudo commandBackground
The ability to change fees required by different actions is not supported by the cli, should be added as part of adding all sequencer actions as cli commands.
Changes
fee-changesudo Subcommand with all fee change actionsTesting
There will be a follow-up PR to add CLI test after the ongoing test refactor is completed.
Related Issues
part of #1474
closes #1615