chore(sequencer): Move all storage keys to a single parent module (ENG-813)#1548
Closed
chore(sequencer): Move all storage keys to a single parent module (ENG-813)#1548
Conversation
…n-verified-storage
Base automatically changed from
fraser/blocks-to-non-verified-storage
to
main
September 26, 2024 12:40
Contributor
Author
|
Closed in favour of #1616. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This groups all keys used for DB entries to a single module, with two submodules, one for verifiable and the other for non-verifiable storage.
Background
DB keys must be unique, and it's easier to assess this when reviewing, updating or adding new keys if the keys are held in a single location.
Changes
storage::verifiable_keysorstorage::nonverifiable_keysas appropriate. The const or generated value of every DB key should be unchanged by this PR.Testing
.snapfiles which correspond to moved snapshot tests are unchanged.Related Issues
Closes #1494.