refactor(proto): fix rust protocol::transactions module name to match proto package name#1378
Closed
itamarreif wants to merge 2 commits intomainfrom
Closed
refactor(proto): fix rust protocol::transactions module name to match proto package name#1378itamarreif wants to merge 2 commits intomainfrom
protocol::transactions module name to match proto package name#1378itamarreif wants to merge 2 commits intomainfrom
Conversation
itamarreif
requested review from
a team,
SuperFluffy,
joroshiba and
noot
as code owners
github-actions
bot
added
proto
Member
|
I opened #1380 which is a much smaller version with the core fix, doesn't touch the non generated types |
Contributor
Author
|
closing in favor of #1380 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brief summary of the changes made, ie "what?"
Background
The rust module name was
transactionpreviously, while the protobuf package name wastransactions(plural). This fixes the rust name to match.Changes
transactions.Testing
existing tests all pass
Related Issues
Link any issues that are related, prefer full github links.
closes