perf(sequencer): add benchmark for prepare_proposal (ENG-660)#1329
Closed
Fraser999 wants to merge 1 commit intoastriaorg:mainfrom
Closed
perf(sequencer): add benchmark for prepare_proposal (ENG-660)#1329Fraser999 wants to merge 1 commit intoastriaorg:mainfrom
Fraser999 wants to merge 1 commit intoastriaorg:mainfrom
Conversation
28ff254 to
9b039da
Compare
Contributor
Author
|
Closed in favour of #1337 (this PR was cut from the wrong repo). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addition of a new benchmark target to assess the performance of the prepare_proposal method in sequencer's
App.Background
Previous perf work has indicated this is a bottleneck. However, making that determination was done via spamoor which is slightly convoluted to run. Before working to improve the performance, we want to have a faster feedback loop on the effects of updates, hence the need for a benchmark which is easy to run and which isolates the slow function.
Changes
appmodule. Currently this has only one case: a mempool filled with transactions containing exclusively transfers. This matches the shape of the data being sent when using spamoor.benchmarkfeature to enable sharing some of the existing test utils.Testing
This is a new test.
Example of running
cargo bench --features=benchmark -qp astria-sequencer appon my Ryzen 7900X:Since rebasing after #1317 has merged, the same run shows (as expected) a slowdown:
Related Issues
Closes #1314.