chore(bridge-withdrawer): Add instrumentation#1324
Merged
ethanoroshiba merged 6 commits intomainfrom Aug 30, 2024
Merged
Conversation
ethanoroshiba
changed the title
ethanoroshiba
added
the
bridge-withdrawer
ethanoroshiba
force-pushed
the
ENG-670/add_instrumentation
branch
from
d77142e to
98bc71c
Compare
ethanoroshiba
added
observability
Fraser999
reviewed
Aug 28, 2024
crates/astria-bridge-withdrawer/src/bridge_withdrawer/submitter/mod.rs
Outdated
Show resolved
Hide resolved
crates/astria-bridge-withdrawer/src/bridge_withdrawer/submitter/mod.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Fraser Hutchison <190532+Fraser999@users.noreply.github.com>
Fraser999
approved these changes
Aug 30, 2024
Contributor
Fraser999
left a comment
Fraser999
left a comment
There was a problem hiding this comment.
One tiny nitpick, but otherwise LGTM.
Co-authored-by: Fraser Hutchison <190532+Fraser999@users.noreply.github.com>
steezeburger
added a commit
that referenced
this pull request
Sep 3, 2024
* main: chore: ibc e2e smoke test (#1284) chore(metrics): restrict `metrics` crate usage to `astria-telemetry` (#1192) fix(charts)!: sequencer-relayer chart correct startup env var (#1437) chore(bridge-withdrawer): Add instrumentation (#1324) chore(conductor): Add instrumentation (#1330) fix(cli, bridge-withdrawer): dont fail entire block due to bad withdraw event (#1409) feat(sequencer, bridge-withdrawer)!: enforce withdrawals consumed (#1391)
jbowen93
pushed a commit
that referenced
this pull request
Sep 3, 2024
## Summary Added instrumentation to `bridge-withdrawer` ## Background Adding instrumentation to all async calls will aid in tracing since spans will be emitted even if no events happen under them. ## Changes - Added instrumentation to all async function calls that are not long-lived. - Minor refactor of `BridgeWithdrawer::run()` to avoid logging outside of spans. - Removed extraneous error logging from functions with `#[instrument(..., err)]`. ## Related Issues Part of #1321 --------- Co-authored-by: Fraser Hutchison <190532+Fraser999@users.noreply.github.com>
jbowen93
pushed a commit
that referenced
this pull request
Sep 6, 2024
## Summary Added instrumentation to `bridge-withdrawer` ## Background Adding instrumentation to all async calls will aid in tracing since spans will be emitted even if no events happen under them. ## Changes - Added instrumentation to all async function calls that are not long-lived. - Minor refactor of `BridgeWithdrawer::run()` to avoid logging outside of spans. - Removed extraneous error logging from functions with `#[instrument(..., err)]`. ## Related Issues Part of #1321 --------- Co-authored-by: Fraser Hutchison <190532+Fraser999@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added instrumentation to
bridge-withdrawerBackground
Adding instrumentation to all async calls will aid in tracing since spans will be emitted even if no events happen under them.
Changes
BridgeWithdrawer::run()to avoid logging outside of spans.#[instrument(..., err)].Related Issues
Part of #1321