refactor(ci): execute ics20 test from statefulset celestia container#1302
Merged
SuperFluffy merged 2 commits intomainfrom Aug 4, 2024
Merged
refactor(ci): execute ics20 test from statefulset celestia container#1302SuperFluffy merged 2 commits intomainfrom
SuperFluffy merged 2 commits intomainfrom
Conversation
github-actions
bot
added
ci
SuperFluffy
force-pushed
the
superfluffy/celestia-local-is-stateful-set
branch
from
b1cce03 to
c27574e
Compare
SuperFluffy
commented
Jul 26, 2024
| # to the chart and its templates, including the app version. | ||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
| version: 0.5.0 | ||
| version: 0.6.0 |
Contributor
Author
There was a problem hiding this comment.
I don't have a good intution for this. Changing the kind of a rollout seems like a major change though.
joroshiba
approved these changes
Jul 31, 2024
steezeburger
added a commit
that referenced
this pull request
Aug 6, 2024
* main: refactor(ci): execute ics20 test from statefulset celestia container (#1302)
ethanoroshiba
pushed a commit
that referenced
this pull request
Aug 13, 2024
…1302) ## Summary Updates the `charts/celestia-local` to spin up `celestia-appd` in a stateful set. Executes the ics20 transfer inside the celestia-app container inside the set. ## Background #1285 updates the ibc ics20 transfer test to require `celestia-appd` and an initialized celestia keystore to be present on the machine running the test. This is undesirable because it pollutes the host environment and creates potential for collisions. Turning `celestia-local` from a kubernetes deployment to a stateful set allows executing the ics20 transfer from inside the container. ## Changes - Rename `charts/celestia-local/templates/deployment.yaml -> charts/celestia-local/templates/statefulsets.yaml` - Changes `kind: Deployment -> kind: StatefulSet` in that file - Update recipes in `charts/deploy.just` to use `kubectl rollout status` instead of `kubectl wait` (the latter does not seem to work with stateful sets) - Use `kubectl exec` against the celestia-app container in the stateful set to initialize the transfer instead of a locally present `celestia-appd` ## Testing This is an update to the ibc ics20 smoke test flow. The test still passes with the expected result. ## Related Issues Closes #1296 Closes #1295
ethanoroshiba
pushed a commit
that referenced
this pull request
Aug 14, 2024
…1302) ## Summary Updates the `charts/celestia-local` to spin up `celestia-appd` in a stateful set. Executes the ics20 transfer inside the celestia-app container inside the set. ## Background #1285 updates the ibc ics20 transfer test to require `celestia-appd` and an initialized celestia keystore to be present on the machine running the test. This is undesirable because it pollutes the host environment and creates potential for collisions. Turning `celestia-local` from a kubernetes deployment to a stateful set allows executing the ics20 transfer from inside the container. ## Changes - Rename `charts/celestia-local/templates/deployment.yaml -> charts/celestia-local/templates/statefulsets.yaml` - Changes `kind: Deployment -> kind: StatefulSet` in that file - Update recipes in `charts/deploy.just` to use `kubectl rollout status` instead of `kubectl wait` (the latter does not seem to work with stateful sets) - Use `kubectl exec` against the celestia-app container in the stateful set to initialize the transfer instead of a locally present `celestia-appd` ## Testing This is an update to the ibc ics20 smoke test flow. The test still passes with the expected result. ## Related Issues Closes #1296 Closes #1295
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
charts/celestia-localto spin upcelestia-appdin a stateful set. Executes the ics20 transfer inside the celestia-app container inside the set.Background
#1285 updates the ibc ics20 transfer test to require
celestia-appdand an initialized celestia keystore to be present on the machine running the test. This is undesirable because it pollutes the host environment and creates potential for collisions. Turningcelestia-localfrom a kubernetes deployment to a stateful set allows executing the ics20 transfer from inside the container.Changes
charts/celestia-local/templates/deployment.yaml -> charts/celestia-local/templates/statefulsets.yamlkind: Deployment -> kind: StatefulSetin that filecharts/deploy.justto usekubectl rollout statusinstead ofkubectl wait(the latter does not seem to work with stateful sets)kubectl execagainst the celestia-app container in the stateful set to initialize the transfer instead of a locally presentcelestia-appdTesting
This is an update to the ibc ics20 smoke test flow. The test still passes with the expected result.
Related Issues
Closes #1296
Closes #1295