chore(test): use a temporary file to not pollute the workspace#1269
Merged
SuperFluffy merged 2 commits intomainfrom Jul 16, 2024
Merged
chore(test): use a temporary file to not pollute the workspace#1269SuperFluffy merged 2 commits intomainfrom
SuperFluffy merged 2 commits intomainfrom
Conversation
SuperFluffy
force-pushed
the
superfluffy/dont-pollute-workspace
branch
from
f6d2960 to
4bd1350
Compare
joroshiba
approved these changes
Jul 15, 2024
steezeburger
added a commit
that referenced
this pull request
Jul 19, 2024
* main: (24 commits) chore: update `bytes` and `ics23` crates (#1279) fix(sequencer): improve and fix instrumentation (#1255) feature(charts): hermes chart fixes, bech32 updates, ibc bridge test (#1130) chore(cli): remove unused rollup cli code (#1275) chore(test): use a temporary file to not pollute the workspace (#1269) chore(sequencer): add mempool benchmarks (#1238) fix(bridge-withdrawer)!: fix nonce handling (#1215) feat(cli, bridge-withdrawer)!: share code between cli and service (#1270) feat(cli): add cmd to collect withdrawal events and submit as actions (#1261) fix(core, bridge, sequencer)!: dismabiguate return addresses (#1266) fix(withdrawer): support withdrawer address that differs from bridge address (#1262) (core, sequencer)!: generate serde traits impls for all protocol protobufs (#1260) fix(charts): add resources for sequencer/cometbft (#1254) chore(sequencer)!: add metrics (#1248) fix(sequencer-utils): fixes issue in `parse_blob` tests (#1243) feat(core, proto)!: make bridge unlock memo string (#1244) fix(conductor): don't panic during panic (#1252) feat(core)!: lowerCamelCase for protobuf json mapping (#1250) refactor(bridge-withdrawer)!: refactor startup to a separate subtask and remove balance check from startup (#1190) fix: rollup archive node configurations (#1249) ...
bharath-123
pushed a commit
that referenced
this pull request
Jul 25, 2024
## Summary Uses a temporary file instead of writing to the workspace during smoke tests. ## Background It's bad practice to pollute the workspace when running tests. This change writes the output to a temporary file instead, and ensures that it is cleaned up after exit. ## Changes - Update the `run-smoke-cli` recipe in `charts/deploy.just` to write to a temporary generated by `mktemp` (without arguments to not run into differences between Darwin/BSD and GNU/Linux) - Use a trap to clean up the temporary on `EXIT`. ## Testing Run `just run-smoke-cli`, observe that the workspace is clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Uses a temporary file instead of writing to the workspace during smoke tests.
Background
It's bad practice to pollute the workspace when running tests. This change writes the output to a temporary file instead, and ensures that it is cleaned up after exit.
Changes
run-smoke-clirecipe incharts/deploy.justto write to a temporary generated bymktemp(without arguments to not run into differences between Darwin/BSD and GNU/Linux)EXIT.Testing
Run
just run-smoke-cli, observe that the workspace is clean.