Skip to content

chore(sequencer-relayer): add timeout to gRPCs to Celestia app #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fraser999 merged 3 commits into from
Jun 18, 2024
Merged

chore(sequencer-relayer): add timeout to gRPCs to Celestia app #1191

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1150f55
add timeout to gRPCs to Celestia app
Fraser999 Jun 17, 2024
f3d69dd
remove needless unit test
Fraser999 Jun 18, 2024
fe4cafb
remove unused imports
Fraser999 Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions crates/astria-sequencer-relayer/src/relayer/celestia_client/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
use std::sync::Arc;
use std::{
sync::Arc,
time::Duration,
};

use astria_core::generated::cosmos::{
base::tendermint::v1beta1::{
Expand Down Expand Up @@ -27,6 +30,9 @@ use super::{
GrpcResponseError,
};

/// All gRPCs will time out with the given duration.
const REQUEST_TIMEOUT: Duration = Duration::from_secs(5);

/// An error when building the `CelestiaClient`.
#[derive(Error, Clone, Debug)]
#[non_exhaustive]
Expand Down Expand Up @@ -80,7 +86,7 @@ impl Builder {
signing_keys: CelestiaKeys,
state: Arc<State>,
) -> Result<Self, BuilderError> {
let grpc_channel = Endpoint::from(uri).connect_lazy();
let grpc_channel = Endpoint::from(uri).timeout(REQUEST_TIMEOUT).connect_lazy();
let address = bech32_encode(&signing_keys.address)?;
Ok(Self {
configured_celestia_chain_id,
Expand All @@ -93,7 +99,7 @@ impl Builder {

/// Returns a new `CelestiaClient` initialized with info retrieved from the Celestia app.
pub(in crate::relayer) async fn try_build(self) -> Result<CelestiaClient, BuilderError> {
let reeceived_celestia_chain_id = self.fetch_celestia_chain_id().await?;
let received_celestia_chain_id = self.fetch_celestia_chain_id().await?;

let Self {
configured_celestia_chain_id,
Expand All @@ -103,14 +109,14 @@ impl Builder {
state,
} = self;

if reeceived_celestia_chain_id != configured_celestia_chain_id {
if received_celestia_chain_id != configured_celestia_chain_id {
return Err(BuilderError::MismatchedCelestiaChainId {
configured: configured_celestia_chain_id,
received: reeceived_celestia_chain_id,
received: received_celestia_chain_id,
});
}

info!(celestia_chain_id = %reeceived_celestia_chain_id, "confirmed celestia chain id");
info!(celestia_chain_id = %received_celestia_chain_id, "confirmed celestia chain id");
state.set_celestia_connected(true);

let tx_client = TxClient::new(grpc_channel.clone());
Expand All @@ -119,7 +125,7 @@ impl Builder {
tx_client,
signing_keys,
address,
chain_id: reeceived_celestia_chain_id,
chain_id: received_celestia_chain_id,
})
}

Expand Down