-
Notifications
You must be signed in to change notification settings - Fork 96
refactor(bridge-withdrawer)!: refactor startup to a separate subtask and remove balance check from startup #1190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
8149513
add error messages
itamarreif 5948dfe
fix service name
itamarreif 5917967
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif f6d2bae
fix name
itamarreif 86a1a03
fix renaming
itamarreif 3018c16
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif ad934e7
startup refactor no tests
itamarreif 45552bc
cleanup tests
itamarreif b8b5c4e
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif 6cdaa25
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif 9d83093
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif 2ff6227
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif e57e7d9
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif dc5109f
address review comments
itamarreif 7daee50
fix clippy
itamarreif 6370462
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif d73d66f
simplify startup handle
itamarreif b4dc531
fix tests
itamarreif 1a19561
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif c65412c
fix problems after merge
itamarreif 2019dd6
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif ebae9aa
clean up retries
itamarreif c57b5b9
comment
itamarreif a8b67a7
fix clippy
itamarreif 277c179
add comment for lint
itamarreif c385713
clean up comments
itamarreif d0a8414
fix tests
itamarreif 72c600c
clean up comment
itamarreif d0011b2
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif 3ff81c1
remove balance check, clean up startup
itamarreif 34e8491
remove clippy allow
itamarreif e5aa336
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif 092b3b5
fix state
itamarreif 82f06a5
address comments
itamarreif 5d93e95
remove dynamic strings
itamarreif cd5646a
minor cleanup?
itamarreif 4ba76a1
all hail the crab
itamarreif dc1a37c
update charts to remove balance fix
itamarreif b4ff789
version bump
itamarreif e6214f1
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif 6e2503c
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif 1977861
fix memo import
itamarreif 18a8510
fix startup
itamarreif 62e1fd9
all hail the crab lord
itamarreif b4a2cee
fix comment
itamarreif 6b23052
update smoke test
itamarreif File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this is a breaking change but it's not marked in the PR title nor explained in the PR message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is mentioned in the PR and there was an issue for it that I forgot to link.
The balance check was unnecessary and removing it resolved some of your previous comments regarding exponential backoffs and serialization errors.