Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
8149513
add error messages
itamarreif Jun 11, 2024
5948dfe
fix service name
itamarreif Jun 12, 2024
5917967
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif Jun 12, 2024
f6d2bae
fix name
itamarreif Jun 13, 2024
86a1a03
fix renaming
itamarreif Jun 13, 2024
3018c16
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif Jun 13, 2024
ad934e7
startup refactor no tests
itamarreif Jun 15, 2024
45552bc
cleanup tests
itamarreif Jun 17, 2024
b8b5c4e
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif Jun 17, 2024
6cdaa25
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif Jun 18, 2024
9d83093
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif Jun 18, 2024
2ff6227
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif Jun 20, 2024
e57e7d9
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif Jun 24, 2024
dc5109f
address review comments
itamarreif Jun 24, 2024
7daee50
fix clippy
itamarreif Jun 24, 2024
6370462
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif Jun 26, 2024
d73d66f
simplify startup handle
itamarreif Jun 28, 2024
b4dc531
fix tests
itamarreif Jun 28, 2024
1a19561
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif Jun 28, 2024
c65412c
fix problems after merge
itamarreif Jun 28, 2024
2019dd6
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif Jun 28, 2024
ebae9aa
clean up retries
itamarreif Jul 1, 2024
c57b5b9
comment
itamarreif Jul 1, 2024
a8b67a7
fix clippy
itamarreif Jul 1, 2024
277c179
add comment for lint
itamarreif Jul 1, 2024
c385713
clean up comments
itamarreif Jul 2, 2024
d0a8414
fix tests
itamarreif Jul 2, 2024
72c600c
clean up comment
itamarreif Jul 2, 2024
d0011b2
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif Jul 5, 2024
3ff81c1
remove balance check, clean up startup
itamarreif Jul 5, 2024
34e8491
remove clippy allow
itamarreif Jul 5, 2024
e5aa336
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif Jul 8, 2024
092b3b5
fix state
itamarreif Jul 8, 2024
82f06a5
address comments
itamarreif Jul 8, 2024
5d93e95
remove dynamic strings
itamarreif Jul 8, 2024
cd5646a
minor cleanup?
itamarreif Jul 8, 2024
4ba76a1
all hail the crab
itamarreif Jul 8, 2024
dc1a37c
update charts to remove balance fix
itamarreif Jul 8, 2024
b4ff789
version bump
itamarreif Jul 8, 2024
e6214f1
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif Jul 8, 2024
6e2503c
Merge branch 'main' of github.com:astriaorg/astria into itamarreif/br…
itamarreif Jul 9, 2024
1977861
fix memo import
itamarreif Jul 9, 2024
18a8510
fix startup
itamarreif Jul 9, 2024
62e1fd9
all hail the crab lord
itamarreif Jul 9, 2024
b4a2cee
fix comment
itamarreif Jul 9, 2024
6b23052
update smoke test
itamarreif Jul 9, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions charts/deploy.just
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ run-smoke-test:
sleep 1
fi
done
if [ $CHECKS -eq $MAX_CHECKS ]; then
if [ $CHECKS -gt $MAX_CHECKS ]; then
echo "Bridge Out Sequencer failure"
exit 1
fi
Expand All @@ -293,8 +293,8 @@ run-smoke-test:
sleep 1
fi
done
if [ $CHECKS -eq $MAX_CHECKS ]; then
echo "Bridge Out Sequencer failure"
if [ $CHECKS -gt $MAX_CHECKS ]; then
echo "Finalization failure"
exit 1
fi
exit 0
Expand Down
2 changes: 1 addition & 1 deletion charts/evm-bridge-withdrawer/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.0.1
version: 0.0.2

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
2 changes: 1 addition & 1 deletion charts/evm-bridge-withdrawer/templates/configmaps.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ data:
ASTRIA_BRIDGE_WITHDRAWER_SEQUENCER_BRIDGE_ADDRESS: "{{ .Values.config.sequencerBridgeAddress }}"
ASTRIA_BRIDGE_WITHDRAWER_FEE_ASSET_DENOMINATION: "{{ .Values.config.feeAssetDenom }}"
ASTRIA_BRIDGE_WITHDRAWER_ROLLUP_ASSET_DENOMINATION: "{{ .Values.config.rollupAssetDenom }}"
ASTRIA_BRIDGE_WITHDRAWER_MIN_EXPECTED_FEE_ASSET_BALANCE: "{{ .Values.config.minExpectedFeeAssetBalance }}"
ASTRIA_BRIDGE_WITHDRAWER_ETHEREUM_CONTRACT_ADDRESS: "{{ .Values.config.evmContractAddress }}"
ASTRIA_BRIDGE_WITHDRAWER_ETHEREUM_RPC_ENDPOINT: "{{ .Values.config.evmRpcEndpoint }}"
ASTRIA_BRIDGE_WITHDRAWER_NO_METRICS: "{{ not .Values.metrics.enabled }}"
Expand All @@ -30,6 +29,7 @@ data:
OTEL_EXPORTER_OTLP_TRACE_HEADERS: "{{ .Values.otel.traceHeaders }}"
OTEL_SERVICE_NAME: "{{ tpl .Values.otel.serviceName . }}"
{{- if not .Values.global.dev }}
ASTRIA_BRIDGE_WITHDRAWER_MIN_EXPECTED_FEE_ASSET_BALANCE: "{{ .Values.config.minExpectedFeeAssetBalance }}"
{{- else }}
{{- end }}
---
Expand Down
3 changes: 0 additions & 3 deletions crates/astria-bridge-withdrawer/local.env.example
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,6 @@ ASTRIA_BRIDGE_WITHDRAWER_SEQUENCER_ADDRESS_PREFIX=astria
# The fee asset denomination to use for the bridge account's transactions.
ASTRIA_BRIDGE_WITHDRAWER_FEE_ASSET_DENOMINATION="nria"

# The minimum expected balance of the fee asset in the bridge account.
ASTRIA_BRIDGE_WITHDRAWER_MIN_EXPECTED_FEE_ASSET_BALANCE=1000000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this is a breaking change but it's not marked in the PR title nor explained in the PR message.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is mentioned in the PR and there was an issue for it that I forgot to link.

The balance check was unnecessary and removing it resolved some of your previous comments regarding exponential backoffs and serialization errors.


# The asset denomination being withdrawn from the rollup.
ASTRIA_BRIDGE_WITHDRAWER_ROLLUP_ASSET_DENOMINATION="nria"

Expand Down
Loading