chore(core, proto)!: remove non-bech32m address bytes#1186
Merged
Conversation
SuperFluffy
force-pushed
the
superfluffy/fully-remove-byte-addresses
branch
from
01583ff to
cdc7d79
Compare
joroshiba
reviewed
Jun 26, 2024
noot
approved these changes
Jun 26, 2024
joroshiba
approved these changes
Jun 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the non-bech32m address bytes field.
Background
The change introduced in #1124 is a breaking change that ripples through the rest of the Astria stack. While in principle we can keep the non-bech32m address around for backward compatibility, in practice it's cleaner to regenesis.
Changes
astria.primitive.v1.Address.inner, reserving its number and name.Testing
Updates and removed all unit tests. All blackbox tests that use addresses in some form still work.
Breaking Changelist
Since this is protobuf breaking it is also network breaking.