chore(bridge-withdrawer): add missing errors and clean up names#1178
Merged
itamarreif merged 9 commits intomainfrom Jun 18, 2024
Merged
chore(bridge-withdrawer): add missing errors and clean up names#1178itamarreif merged 9 commits intomainfrom
itamarreif merged 9 commits intomainfrom
Conversation
…idge-withdrawer-errorscleanup
…idge-withdrawer-errorscleanup
Fraser999
approved these changes
Jun 18, 2024
Contributor
Fraser999
left a comment
Fraser999
left a comment
There was a problem hiding this comment.
One non-blocking nitpick, otherwise LGTM.
crates/astria-bridge-withdrawer/src/bridge_withdrawer/submitter/signer.rs
Outdated
Show resolved
Hide resolved
…idge-withdrawer-errorscleanup
steezeburger
added a commit
that referenced
this pull request
Jun 19, 2024
* main: chore(bridge-withdrawer): add missing errors and clean up names (#1178) feat(sequencer): add ttl and invalid cache to app mempool (#1138) chore(astria-merkle): add benchmarks (#1179) chore(sequencer-relayer): add timeout to gRPCs to Celestia app (#1191) refactor(core): parse ics20 denoms as ibc or trace prefixed variants (#1181) Mycodecrafting/sequencer seed node (#1188) chore: register all metrics during startup (#1144) feat(charts): option to purge geth mempool (#1182)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add missing errors and clean up names
Background
Various clean up tasks needed after rushing code through over the weekend.
Changes
ServicetoBridgeWithdrawerto match the rest of the monorepo