Conversation
github-actions
bot
added
the
documentation
itamarreif
approved these changes
Jun 13, 2024
Contributor
itamarreif
left a comment
itamarreif
left a comment
There was a problem hiding this comment.
looks good other than the deposit/withdrawal memo thing.
| - a user initiates an ICS20 withdrawal from some IBC chain to Astria. | ||
| - the user sets the destination chain address as the sequencer bridge address | ||
| which corresponds to the rollup they wish to deposit to. | ||
| - the user sets the withdrawal memo to their rollup address. |
Contributor
There was a problem hiding this comment.
shouldn't this be deposit instead of withdrawal memo?
Contributor
Author
There was a problem hiding this comment.
it depends on the pov, it's a withdrawal from some other IBC chain to astria, which makes it a deposit to astria. but it's the memo of the original withdrawal that has to be set by the user
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add spec doc which explains the sequencer's native bridging protocol and related actions.
Background
we didn't have any spec doc before on how the bridging protocol worked.
Changes