chore(chart)!: update default cometbft config vals#1173
Closed
chore(chart)!: update default cometbft config vals#1173
Conversation
noot
reviewed
Jun 11, 2024
| # This only accounts for raw transactions (e.g. given 1MB transactions and | ||
| # max_txs_bytes=5MB, mempool will only accept 5 transactions). | ||
| max_txs_bytes = 1073741824 | ||
| max_txs_bytes = 100_000_000 |
Contributor
There was a problem hiding this comment.
Decreasing mempool size from 1GB to 100 MB, better default configs, same for other values.
noot
reviewed
Jun 11, 2024
Comment on lines
+53
to
+54
| "max_age_duration": "1209600000000000", | ||
| "max_age_num_blocks": "4000000", |
noot
approved these changes
Jun 11, 2024
Member
Author
|
Fixed as a part of #1193 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates default CometBFT configuration, and genesis.
Background
We have been running on mostly defaults without much thought to it, gave a more thorough review.
Breaking Changelist