move all sources into a cargo workspace#1
Merged
SuperFluffy merged 1 commit intomainfrom May 17, 2023
Merged
Conversation
this steps just moves everything out of `sources/` and places it into `crates/`. `cargo check` passes after adding making the crates workspace members in the root `Cargo.toml`. The crates do not refer to each other by path, and they are also not yet cleaned up.
joroshiba
previously approved these changes
May 16, 2023
joroshiba
reviewed
May 16, 2023
Member
joroshiba
left a comment
joroshiba
left a comment
There was a problem hiding this comment.
Should we leave the existing github workflows until we have consolidated?
Contributor
Author
|
This is as intended. The next (and last) thing I'll add tomorrow are GitHub workflows. The main difficulty is figuring out how to set up testing between conductor and sequencer-relayer in CI given that they are now tighter coupled. For this to make sense |
joroshiba
approved these changes
May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this steps just moves everything out of
sources/and places it intocrates/.cargo checkpasses after adding making the crates workspace members in the rootCargo.toml.The crates do not refer to each other by path, and they are also not yet cleaned up.