Merged
Conversation
mycodecrafting
approved these changes
Oct 8, 2024
bharath-123
added a commit
that referenced
this pull request
Oct 11, 2024
Acquire a mutex lock and unlock while removing transactions from the mempool to avoid concurrent errors on the underlying maps. Changes made: 1. Acquire the pool mutex lock in `ClearAstriaOrdered` 2. Add a test in `legacypool_test.go` called `TestRemoveTxSanity` which adds a bunch of pending txs and removes them using `removeTx`. We use `ValidatePoolInternals` method to ensure that the pool state is not corrupted. This test is a sanity check for us to validate that `removeTx` works as intended and does not have adverse side effects. 3. Add a test in for the ExecutionAPI where we add an invalid tx which will have to be removed. We verify that the mempool is cleared completely after it --------- Co-authored-by: Bharath <vedabharath12345@gmail.com>
bharath-123
added a commit
that referenced
this pull request
Nov 22, 2024
Acquire a mutex lock and unlock while removing transactions from the mempool to avoid concurrent errors on the underlying maps. Changes made: 1. Acquire the pool mutex lock in `ClearAstriaOrdered` 2. Add a test in `legacypool_test.go` called `TestRemoveTxSanity` which adds a bunch of pending txs and removes them using `removeTx`. We use `ValidatePoolInternals` method to ensure that the pool state is not corrupted. This test is a sanity check for us to validate that `removeTx` works as intended and does not have adverse side effects. 3. Add a test in for the ExecutionAPI where we add an invalid tx which will have to be removed. We verify that the mempool is cleared completely after it --------- Co-authored-by: Bharath <vedabharath12345@gmail.com>
bharath-123
added a commit
that referenced
this pull request
Nov 22, 2024
cherry-pick: fix: use mutex lock for tx removal (#51)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acquire a mutex lock and unlock while removing transactions from the mempool to avoid concurrent errors on the underlying maps.
Changes made:
ClearAstriaOrderedlegacypool_test.gocalledTestRemoveTxSanitywhich adds a bunch of pending txs and removes them usingremoveTx. We useValidatePoolInternalsmethod to ensure that the pool state is not corrupted. This test is a sanity check for us to validate thatremoveTxworks as intended and does not have adverse side effects.