Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read support for steam oven/microwave combination #603

Merged
merged 10 commits into from
Dec 16, 2024
Merged

Conversation

DAccord
Copy link

@DAccord DAccord commented Dec 15, 2024

Adding read support for steam oven/microwave combination, i.e. Miele integration will now show correct program names when using the steam oven/microwave combination. Write support not included.
Tested with Miele DGM 7440.

Copy link
Owner

@astrandb astrandb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Where did you find all these strings?
A handful of minor comments...

custom_components/miele/const.py Outdated Show resolved Hide resolved
custom_components/miele/translations/en.json Outdated Show resolved Hide resolved
custom_components/miele/translations/en.json Outdated Show resolved Hide resolved
custom_components/miele/translations/en.json Show resolved Hide resolved
custom_components/miele/translations/en.json Show resolved Hide resolved
custom_components/miele/translations/en.json Outdated Show resolved Hide resolved
custom_components/miele/translations/en.json Outdated Show resolved Hide resolved
@DAccord
Copy link
Author

DAccord commented Dec 15, 2024

Took me a 2-3 afternoons to try out all the programs on my DGM 7440 and record the IDs and corresponding names.

@DAccord DAccord requested a review from astrandb December 15, 2024 18:11
Copy link
Owner

@astrandb astrandb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little one left.
Note that en.json will be sorted in alphabetic order when up/downloaded to Lokalise.

custom_components/miele/translations/en.json Outdated Show resolved Hide resolved
@DAccord DAccord requested a review from astrandb December 16, 2024 19:18
@astrandb
Copy link
Owner

Thank you @DAccord

@astrandb astrandb merged commit 5832029 into astrandb:main Dec 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants