Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/correction of dishwasher programs with update of language files for German and English #538

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

alehofde
Copy link
Contributor

No description provided.

@alehofde
Copy link
Contributor Author

Tested with Device: Miele G7915 dishwasher

Copy link
Owner

@astrandb astrandb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.
This may very well be correct for your dishwasher model. But the Miele world is not that simple. A sad fact is that 44 can mean different things in different dishwasher models.
Are you sure that no other models use the deleted program? Otherwise I suggest that you leave code 42.
The german translation should be handled in Lokalise, de.json will be overwritten at next export from Lokalise. I suggest that you delete de.json in this PR.

@alehofde
Copy link
Contributor Author

Hi
Yes, you are right, the program ID 42 can remain.
However, I do not understand your second point. I have added the new entries in de.json and en.json. Where else should I do that?

@astrandb
Copy link
Owner

Please read more here for translation: https://github.com/astrandb/miele?tab=readme-ov-file#translation

Make your additions to en.json. When this PR is merged the english file is loaded into Lokalise automatically and you and orther translators can go there and update the supported languages. Lokalise will then create PR:s for all language files during the release process. English terms will be default if translations are missing.

@astrandb astrandb merged commit 819325d into astrandb:main Nov 12, 2024
3 checks passed
@astrandb
Copy link
Owner

Thank you, @alehofde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants