Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use common entity class #522

Merged
merged 16 commits into from
Aug 7, 2024
Merged

Use common entity class #522

merged 16 commits into from
Aug 7, 2024

Conversation

CFenner
Copy link
Contributor

@CFenner CFenner commented Aug 6, 2024

Uses a common entity class to reuse code for _attr_device_info and other common attributes like _attr_has_entity_name, _attr_unique_id, ent, ...

  • real world test

@CFenner CFenner marked this pull request as ready for review August 6, 2024 07:01
@astrandb astrandb added the code quality Code quality and optimizations label Aug 7, 2024
Copy link
Owner

@astrandb astrandb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this work. I have had this clean-up on my own to-do list for a long time but never did anything about it.
I will do some verification and testing and then it should be ready to merge.

@astrandb astrandb merged commit 48dccb7 into astrandb:main Aug 7, 2024
3 checks passed
@CFenner CFenner deleted the entity branch August 7, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code quality and optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants