Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add German translation #13

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Conversation

mundschenk-at
Copy link
Contributor

Adds German translation.

Note: I'm not totally sure what the best translation for "Supercooling" and "Superheating" is (Superfreezing is definitely "SuperFrost", a named feature/trademark). There is a named feature/trademark "SuperKühlen", but I fewer people know about it ("SuperFrost" and similarly named features are pretty much standard for high quality freezers, regardless of manufacturer). IPSymcon uses "Schnellkühlen" and "Schnellaufheizen" ("fast cooling" and "fast heating"), which is more descriptive. There does not appear to be a named feature/trademark equivalent to "Superheating" on the German Miele site at this point.

@astrandb
Copy link
Owner

I got SuperKühlen/SuperFrost when reading my devices with Swagger.
However, in the IOS app the swedish translation in inconsistent. SuperFrost in one place and Snabbinfrysning in another.
The latter is more descriptive.
FUBAR as you stated before.

I have picked up the list of program phases you pointed at the other day. I will update the english translation file now and then you can follow up with the german one before we merge.

@astrandb astrandb added the translation Add or update translations label Jan 26, 2022
@astrandb
Copy link
Owner

Please see PR #14 for new entries in sensor.en.json

@mundschenk-at
Copy link
Contributor Author

Please see PR #14 for new entries in sensor.en.json

I've updated the PR with the new translations.

@astrandb
Copy link
Owner

Looks good! Thank you.

@astrandb astrandb merged commit 0d19da5 into astrandb:main Jan 26, 2022
@mundschenk-at mundschenk-at deleted the german-translation branch January 27, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Add or update translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants