Merge sundry bugfixes from pre-0.14 #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved debugging output and error handling. Better documentation in comments. For example, new xchandler for errors now breaks the mainloop by sending ourselves a ClientMessage event when an error occurs. New xcchangeprop() frontend wraps and handles errors from XChangeProperty(). Also, we now check for NULL before using XFree, handle SELECTION_REFUSED and delete properties, allow chunk sizes up to (almost) the maximum the X display can handle (previously was 6%).
Previous xctest was failing because, ironically, it had a bug that should have caused xclip to fail, but xclip wasn't checking the error messages and so reported everything was fine.
The old style cut buffer was not being correctly handled before. Particularly, error messages were being ignored. And errors are easy to get since BUFFERCUT can only hold 16 MiB of data and has no option for INCRemental chunks. The -v flag should always means -verbose, not -version. Likewise, -i, -o and others should have fixed meanings even if we later add flags that start with 'i', 'o', et cetera. -c is now shorthand for "-selection clipboard", and -T is short for "-t TARGETS". XSetSelectionOwner should *not* use CurrentTime, according to ICCCM section 2.1. This patch doesn't fix that yet, but it makes the first step. Added in a stub variable "ownertime" which, for now, is just CurrentTime. TODO: Eventually xclip should append zero-length to a property and get the timestamp from the server's PropertyNotify event. Added some sanity tests to make sure we never get in a strange state with sloop.
Uses groff to make a pdf. Also: Create a 'watch' target so that we can see the pdf change while editing the manpage every time xclip.1 is saved. Add a 'test' target so make test runs xctest. Make sure the 'dist' target actually includes all the files, including xctest.
|
Hi @hackerb9, I recently volunteered to help @astrand with maintenance of xclip, but from the looks of this PR it seems like you should certainly be also! I've merged a couple small things that now conflict, are you interested in updating your PR? There looks like a /ton/ of great fixes in here, thank you! |
|
@hackerb9 just pinging again to see if you're interested or might have time to re-sync your PR? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.