Include Git member information when getting metadata from cache

[ericmarkmartin]

Summary

Include the git_member when fetching metadata from cache.

h/t to @PhilipVinc for the suggested fix

Resolves #8887

Test Plan

Pending

[ericmarkmartin]

It looks like some of the failing tests are the "too many requests" thing I alluded to in my comment on the issue

[charliermarsh]

Yeah I think something is up with that index. I should look into removing our dependency on it.

[charliermarsh]

This seems right, but is there a way to test it?

[ericmarkmartin]

This seems right, but is there a way to test it?

Could we set up a packse like the example given in the issue (see https://github.com/PhilipVinc/uvtest/tree/dab673b4ad5c6f1335c491baf49ad4965562e876)?

Also, I generally am pretty clueless about uv's testing story (I know it's snapshot based, but that's about it) but would be eager to learn by writing some tests here

[zanieb]

If it would help we could add a repository in our test org, e.g. https://github.com/astral-test/uv-submodule-pypackage

I'm not sure I understand the issue here though.

[ericmarkmartin]

If it would help we could add a repository in our test org, e.g. https://github.com/astral-test/uv-submodule-pypackage

That could be helpful. I take it that'd be easier than getting packse to serve git repos? One maybe relevant question here is whether we can use git+ with file-scheme urls?

[zanieb]

I take it that'd be easier than getting packse to serve git repos?

Yeah this would probably be a pain.

One maybe relevant question here is whether we can use git+ with file-scheme urls?

I don't quite follow, perhaps you should tell me what a test case would look like given a uv binary and I can help construct it? Perhaps as an answer to your question, a test could just clone a repository to a temporary directory then pass that path to uv?

[ericmarkmartin]

Perhaps as an answer to your question, a test could just clone a repository to a temporary directory then pass that path to uv?

For sure, I just wasn't at my computer earlier. I just confirmed that using git+ with file:// urls works, though unfortunately testing this with @PhilpVinc's test repository (see linked issue) had the conflicting URL issue reoccur 😞

[konstin]

If you need inspiration for tests, there are transitive_dep_in_git_workspace_no_root and transitive_dep_in_git_workspace_with_root from previous bug fixes in the area

[charliermarsh]

I'd like to get this merged today so we can release it. I'll add a test if needed.

[ericmarkmartin]

I'd like to get this merged today so we can release it. I'll add a test if needed.

Hey, Apologies for not getting to this, I had to get ready for a vacation. I’m out of the country without my personal computer right now so I think the chances I can do this today are pretty low.

[charliermarsh]

@ericmarkmartin -- No problem at all!